Skip to content

Commit dcb16b3

Browse files
Cherry-pick from develop, for srt utest. v5.0.185 (ossrs#3816)
1 parent 477a86b commit dcb16b3

8 files changed

+14
-12
lines changed

trunk/doc/CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ The changelog for SRS.
77
<a name="v5-changes"></a>
88

99
## SRS 5.0 Changelog
10+
* v5.0, 2023-09-28, Merge [#3816](https://github.com/ossrs/srs/pull/3816): cherry-pick from develop, for srt utest. v5.0.185 (#3816)
1011
* v5.0, 2023-09-21, Merge [#3806](https://github.com/ossrs/srs/pull/3806): Build: Support sys-ssl for srt. v5.0.184 (#3806)
1112
* v5.0, 2023-09-21, Merge [#3808](https://github.com/ossrs/srs/pull/3808): Upgrade libsrt to v1.5.3. v5.0.183 (#3808)
1213
* v5.0, 2023-09-21, Merge [#3404](https://github.com/ossrs/srs/pull/3404): WebRTC: Support WHEP for play. v5.0.182 (#3404)

trunk/src/app/srs_app_config.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -7893,7 +7893,7 @@ unsigned short SrsConfig::get_srt_listen_port()
78937893
return (unsigned short)atoi(conf->arg0().c_str());
78947894
}
78957895

7896-
int SrsConfig::get_srto_maxbw()
7896+
int64_t SrsConfig::get_srto_maxbw()
78977897
{
78987898
SRS_OVERWRITE_BY_ENV_INT("srs.srt_server.maxbw"); // SRS_SRT_SERVER_MAXBW
78997899

@@ -7907,7 +7907,7 @@ int SrsConfig::get_srto_maxbw()
79077907
if (!conf || conf->arg0().empty()) {
79087908
return DEFAULT;
79097909
}
7910-
return atoi(conf->arg0().c_str());
7910+
return atoll(conf->arg0().c_str());
79117911
}
79127912

79137913
int SrsConfig::get_srto_mss()

trunk/src/app/srs_app_config.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,7 @@ class SrsConfig
673673
// Get the srt service listen port
674674
virtual unsigned short get_srt_listen_port();
675675
// Get the srt SRTO_MAXBW, max bandwith, default is -1.
676-
virtual int get_srto_maxbw();
676+
virtual int64_t get_srto_maxbw();
677677
// Get the srt SRTO_MSS, Maximum Segment Size, default is 1500.
678678
virtual int get_srto_mss();
679679
// Get the srt SRTO_TSBPDMODE, timestamp base packet delivery mode, default is false.

trunk/src/app/srs_app_srt_server.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ srs_error_t SrsSrtAcceptor::set_srt_opt()
6666
srs_error_t err = srs_success;
6767

6868
if ((err = srs_srt_set_maxbw(listener_->fd(), _srs_config->get_srto_maxbw())) != srs_success) {
69-
return srs_error_wrap(err, "set opt maxbw=%d failed", _srs_config->get_srto_maxbw());
69+
return srs_error_wrap(err, "set opt maxbw=%" PRId64 " failed", _srs_config->get_srto_maxbw());
7070
}
7171

7272
if ((err = srs_srt_set_mss(listener_->fd(), _srs_config->get_srto_mss())) != srs_success) {

trunk/src/core/srs_core_version5.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99

1010
#define VERSION_MAJOR 5
1111
#define VERSION_MINOR 0
12-
#define VERSION_REVISION 184
12+
#define VERSION_REVISION 185
1313

1414
#endif

trunk/src/protocol/srs_protocol_srt.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ srs_error_t srs_srt_nonblock(srs_srt_t srt_fd)
221221
return srs_success;
222222
}
223223

224-
srs_error_t srs_srt_set_maxbw(srs_srt_t srt_fd, int maxbw)
224+
srs_error_t srs_srt_set_maxbw(srs_srt_t srt_fd, int64_t maxbw)
225225
{
226226
SET_SRT_OPT(srt_fd, SRTO_MAXBW, maxbw);
227227
return srs_success;
@@ -311,7 +311,7 @@ srs_error_t srs_srt_set_pbkeylen(srs_srt_t srt_fd, int pbkeylen)
311311
return srs_success;
312312
}
313313

314-
srs_error_t srs_srt_get_maxbw(srs_srt_t srt_fd, int& maxbw)
314+
srs_error_t srs_srt_get_maxbw(srs_srt_t srt_fd, int64_t& maxbw)
315315
{
316316
GET_SRT_OPT(srt_fd, SRTO_MAXBW, maxbw);
317317
return srs_success;

trunk/src/protocol/srs_protocol_srt.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ extern srs_error_t srs_srt_listen(srs_srt_t srt_fd, std::string ip, int port);
3434
extern srs_error_t srs_srt_nonblock(srs_srt_t srt_fd);
3535

3636
// Set SRT options.
37-
extern srs_error_t srs_srt_set_maxbw(srs_srt_t srt_fd, int maxbw);
37+
extern srs_error_t srs_srt_set_maxbw(srs_srt_t srt_fd, int64_t maxbw);
3838
extern srs_error_t srs_srt_set_mss(srs_srt_t srt_fd, int mss);
3939
extern srs_error_t srs_srt_set_payload_size(srs_srt_t srt_fd, int payload_size);
4040
extern srs_error_t srs_srt_set_connect_timeout(srs_srt_t srt_fd, int timeout);
@@ -51,7 +51,7 @@ extern srs_error_t srs_srt_set_passphrase(srs_srt_t srt_fd, const std::string& p
5151
extern srs_error_t srs_srt_set_pbkeylen(srs_srt_t srt_fd, int pbkeylen);
5252

5353
// Get SRT options.
54-
extern srs_error_t srs_srt_get_maxbw(srs_srt_t srt_fd, int& maxbw);
54+
extern srs_error_t srs_srt_get_maxbw(srs_srt_t srt_fd, int64_t& maxbw);
5555
extern srs_error_t srs_srt_get_mss(srs_srt_t srt_fd, int& mss);
5656
extern srs_error_t srs_srt_get_payload_size(srs_srt_t srt_fd, int& payload_size);
5757
extern srs_error_t srs_srt_get_connect_timeout(srs_srt_t srt_fd, int& timeout);

trunk/src/utest/srs_utest_srt.cpp

+4-3
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ VOID TEST(ServiceSrtPoller, SrtSetGetSocketOpt)
7474
HELPER_EXPECT_SUCCESS(srs_srt_socket(&srt_fd));
7575
HELPER_EXPECT_SUCCESS(srs_srt_nonblock(srt_fd));
7676

77-
int maxbw = 20000;
77+
int64_t maxbw = 20000;
7878
int mss = 1400;
7979
int payload_size = 1316;
8080
int connect_timeout = 5000;
@@ -104,10 +104,11 @@ VOID TEST(ServiceSrtPoller, SrtSetGetSocketOpt)
104104

105105
bool b;
106106
int i = 0;
107+
int64_t i64 = 0;
107108
std::string s;
108109

109-
HELPER_EXPECT_SUCCESS(srs_srt_get_maxbw(srt_fd, i));
110-
EXPECT_EQ(i, maxbw);
110+
HELPER_EXPECT_SUCCESS(srs_srt_get_maxbw(srt_fd, i64));
111+
EXPECT_EQ(i64, maxbw);
111112
HELPER_EXPECT_SUCCESS(srs_srt_get_mss(srt_fd, i));
112113
EXPECT_EQ(i, mss);
113114
HELPER_EXPECT_SUCCESS(srs_srt_get_payload_size(srt_fd, i));

0 commit comments

Comments
 (0)