Skip to content

Commit 8e314a3

Browse files
committed
skip grpc client close when removing cluster node from orchestrators
1 parent 563be9a commit 8e314a3

File tree

1 file changed

+1
-7
lines changed
  • packages/api/internal/orchestrator

1 file changed

+1
-7
lines changed

packages/api/internal/orchestrator/cache.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -169,13 +169,7 @@ func (o *Orchestrator) syncClusterNode(ctx context.Context, node *Node, instance
169169

170170
if !nodeFound {
171171
zap.L().Info("Node is not active anymore", logger.WithNodeID(node.Info.ID), logger.WithClusterID(node.ClusterID))
172-
173-
// Close the connection to the node
174-
err := node.Client.Close()
175-
if err != nil {
176-
zap.L().Error("Error closing connection to node", zap.Error(err), logger.WithNodeID(node.Info.ID), logger.WithClusterID(node.ClusterID))
177-
}
178-
172+
// we are not closing grpc connection, because it is shared between all cluster nodes and it's handled by the cluster
179173
o.nodes.Remove(node.Info.ID)
180174
return
181175
}

0 commit comments

Comments
 (0)