Skip to content

Add paging for query results #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joewiz opened this issue Jan 17, 2019 · 4 comments
Open

Add paging for query results #56

joewiz opened this issue Jan 17, 2019 · 4 comments

Comments

@joewiz
Copy link
Member

joewiz commented Jan 17, 2019

Currently query results are truncated to 10 items, with no mechanism to page through additional results.

Adding previous & next commands would be great. Exposing these via toolbar (see #53) would natural.

Adding a setting for the number of results per page would also be convenient.

@duncdrum
Copy link
Contributor

actually I think the way query results are handled is in need of an overhaul. There should not be a query-results file that appears in the repo in certain conditions, but not others.
But first we need @wolfgangmm to add his token to travis ;-)

@joewiz
Copy link
Member Author

joewiz commented Jan 17, 2019

What do you mean by "appears... in certain conditions, but not others"? For me, query results always appear in a new (unsaved) editor pane labeled "query-result" in the lower half of Atom's window.

@duncdrum
Copy link
Contributor

yes and sometime they are written to a tmp location and sometimes into the code repo I'm currently working on

@joewiz
Copy link
Member Author

joewiz commented Jan 17, 2019

Without you hitting save? Reproducible? Sounds like a bug - sufficiently different from the issue here that it’s worth its own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants