fix: Commands only available in Assembly (#2731)

Author: ilidio-lopes

server/engine/src/main/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSFreeMainOptionsCheckUtility.java

@@ -60,6 +60,8 @@ public <E extends ParserRuleContext> void checkOptions(E ctx) {
         checkDuplicates(ctx);
     }
     private void checkOpts(CICSParser.Cics_freemain_optsContext ctx) {
+        CICSParser.Cics_freemainContext parentCtx = (CICSParser.Cics_freemainContext) ctx.getParent();
+        checkHasIllegalOptions(parentCtx.FREEMAIN64(), "FREEMAIN64 is only available in Assembly");
         checkHasExactlyOneOption("DATA or DATAPOINTER", ctx, ctx.DATA(), ctx.DATAPOINTER());
     }
 

server/engine/src/main/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSGetMain64OptionsUtility.java

@@ -66,6 +66,8 @@ public <E extends ParserRuleContext> void checkOptions(E ctx) {
 
   @SuppressWarnings("unchecked")
   private void checkGetMain(CICSParser.Cics_getmain64_bodyContext ctx) {
+    CICSParser.Cics_getmain64Context parentCtx = (CICSParser.Cics_getmain64Context) ctx.getParent();
+    checkHasIllegalOptions(parentCtx.GETMAIN64(), "GETMAIN64 is only available in Assembly");
     checkHasMandatoryOptions(ctx.SET(), ctx, "SET");
     checkHasMandatoryOptions(ctx.FLENGTH(), ctx, "FLENGTH");
     if (ctx.LOCATION().isEmpty()) checkHasIllegalOptions(ctx.EXECUTABLE(), "EXECUTABLE without LOCATION");

server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCICSFreeMainStatement.java

@@ -26,13 +26,15 @@
 
 /**
  * Test CICS Freemain & Freemain64 commands. Documentation link:
- *<a https://www.ibm.com/docs/en/cics-ts/6.x?topic=summary-freemain"> Freemain Command</a>
- *<a https://www.ibm.com/docs/en/cics-ts/6.x?topic=summary-freemain64"> Freemain64 Command</a>
+ *<a href="https://www.ibm.com/docs/en/cics-ts/6.x?topic=summary-freemain"> Freemain Command</a>
+ *<a href="https://www.ibm.com/docs/en/cics-ts/6.x?topic=summary-freemain64"> Freemain64 Command</a>
  * <p>This class tests all variations of the Freemain commands found in the links above.
  */
 public class TestCICSFreeMainStatement {
     private static final String FREEMAIN_DATA_VALID =
             "FREEMAIN DATA({$varFour})";
+    private static final String FREEMAIN64_DATA_INVALID =
+            "{FREEMAIN64|errorOne} DATA({$varFour})";
     private static final String FREEMAIN_DATAPOINTER_VALID =
             "FREEMAIN DATAPOINTER({$varFour})";
     private static final String FREEMAIN_DATA_MISSING_INVALID =
@@ -44,6 +46,21 @@ public class TestCICSFreeMainStatement {
     void testFreeMainDataValid() {
         CICSTestUtils.noErrorTest(FREEMAIN_DATA_VALID);
     }
+
+    @Test
+    void testFreeMain64Invalid() {
+        Map<String, Diagnostic> expectedDiagnostic =
+                ImmutableMap.of(
+                        "errorOne",
+                        new Diagnostic(
+                                new Range(),
+                                "Invalid option provided: FREEMAIN64 is only available in Assembly",
+                                DiagnosticSeverity.Error,
+                                ErrorSource.PARSING.getText())
+                );
+        CICSTestUtils.errorTest(FREEMAIN64_DATA_INVALID, expectedDiagnostic);
+    }
+
     @Test
     void testFreeMainDataPointerValid() {
         CICSTestUtils.noErrorTest(FREEMAIN_DATAPOINTER_VALID);

server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsGetMain64.java

@@ -32,71 +32,18 @@
  * <p>This class tests all variations of the GETMAIN64 command found in the link above.
  */
 public class TestCicsGetMain64 {
-    private static final String ALL_VALID_ONE = "GETMAIN64 SET({$varOne}) FLENGTH({$varTwo})  LOCATION({$varThree}) EXECUTABLE SHARED NOSUSPEND USERDATAKEY";
-    private static final String ALL_VALID_TWO = "GETMAIN64 FLENGTH({$varTwo}) SHARED EXECUTABLE LOCATION({$varTwo}) NOSUSPEND CICSDATAKEY SET({$varOne})";
-
-    private static final String SOME_VALID_ONE = "GETMAIN64 FLENGTH({$varThree}) SHARED CICSDATAKEY SET({$varOne}) LOCATION({$varTwo})";
-    private static final String SOME_VALID_TWO = "GETMAIN64 NOSUSPEND FLENGTH({$varThree}) SET({$varOne}) LOCATION({$varTwo}) EXECUTABLE";
-    private static final String SOME_VALID_THREE = "GETMAIN64 SET({$varOne}) NOSUSPEND FLENGTH({$varTwo}) USERDATAKEY";
-
-    private static final String BARE_VALID = "GETMAIN64 FLENGTH({$varTwo}) SET({$varOne})";
-
-    private static final String INVALID_ONE = "GETMAIN64 SET({$varTwo}) FLENGTH({$varThree}) {EXECUTABLE|error1} SHARED";
-    private static final String INVALID_TWO = "GETMAIN64 {USERDATAKEY|error1} FLENGTH({$varTwo}) SET({$varOne}) {CICSDATAKEY|error1}";
-
-    @Test
-    void testAllValidOne() {
-        CICSTestUtils.noErrorTest(ALL_VALID_ONE);
-    }
-
-    @Test
-    void testAllValidTwo() {
-        CICSTestUtils.noErrorTest(ALL_VALID_TWO);
-    }
-
-    @Test
-    void testSomeValidOne() {
-        CICSTestUtils.noErrorTest(SOME_VALID_ONE);
-    }
-
-    @Test
-    void testSomeValidTwo() {
-        CICSTestUtils.noErrorTest(SOME_VALID_TWO);
-    }
-
-    @Test
-    void testSomeValidThree() {
-        CICSTestUtils.noErrorTest(SOME_VALID_THREE);
-    }
-
-    @Test
-    void testBareValidOne() {
-        CICSTestUtils.noErrorTest(BARE_VALID);
-    }
+    private static final String INVALID_ONE = "{GETMAIN64|errorOne} SET({$varTwo}) FLENGTH({$varThree}) SHARED";
 
     @Test
     void testInvalidOne() {
         Map<String, Diagnostic> expectedDiagnostic =
                 ImmutableMap.of(
-                        "error1",
+                        "errorOne",
                         new Diagnostic(
                                 new Range(),
-                                "Invalid option provided: EXECUTABLE without LOCATION",
+                                "Invalid option provided: GETMAIN64 is only available in Assembly",
                                 DiagnosticSeverity.Error,
                                 ErrorSource.PARSING.getText()));
         CICSTestUtils.errorTest(INVALID_ONE, expectedDiagnostic);
     }
-
-    @Test
-    void testInvalidTwo() {
-        Map<String, Diagnostic> expectedDiagnostic =
-                ImmutableMap.of(
-                        "error1",
-                        new Diagnostic(
-                                new Range(),
-                                "Exactly one option required, options are mutually exclusive: USERDATAKEY or CICSDATAKEY",
-                                DiagnosticSeverity.Error,
-                                ErrorSource.PARSING.getText()));
-        CICSTestUtils.errorTest(INVALID_TWO, expectedDiagnostic);
-    }
 }