Skip to content

feat: Show diagnostic only for opened documents #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 26, 2023

Conversation

Nurkambay
Copy link
Contributor

@Nurkambay Nurkambay commented Jul 7, 2023

How Has This Been Tested?

  1. Open a document with a copybook that contains an error
  2. Ensure there are no errors for the copybook file
  3. Open the copybook
  4. Ensure that errors for copybooks appeared
  5. Close the copybook file
  6. Ensure errors for copybook disappeared

Also, all the following regressions should be tested:

  1. Hover on a variable
  2. Go to the definition
  3. Autocompletion
  4. List of actions for the variable/section, etc.
  5. Open the same analyzed document for the second time (should be fast because all diagnostics and outline results are already here)

Also, it should fix #491

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Nurkambay Nurkambay requested review from ishche and ap891843 July 7, 2023 12:05
@Nurkambay Nurkambay force-pushed the feat-diagnostic branch 4 times, most recently from eebaf46 to e11e292 Compare July 7, 2023 14:15
@Nurkambay Nurkambay marked this pull request as draft July 10, 2023 07:17
@Nurkambay Nurkambay force-pushed the feat-diagnostic branch 3 times, most recently from 4243647 to e9173c0 Compare July 10, 2023 09:46
@Nurkambay Nurkambay marked this pull request as ready for review July 10, 2023 09:47
@Nurkambay Nurkambay force-pushed the feat-diagnostic branch 6 times, most recently from 4640f12 to 8d115fb Compare July 11, 2023 06:59
@Nurkambay Nurkambay force-pushed the feat-diagnostic branch 10 times, most recently from f4b2cdb to 5e6de41 Compare July 18, 2023 09:16
@Nurkambay Nurkambay force-pushed the feat-diagnostic branch 6 times, most recently from 33ccd8e to 2b92217 Compare July 21, 2023 11:26
@Nurkambay Nurkambay force-pushed the feat-diagnostic branch 8 times, most recently from 1cfed48 to 46bffda Compare July 24, 2023 15:41
@Nurkambay Nurkambay force-pushed the feat-diagnostic branch 3 times, most recently from 22caec4 to d7b0735 Compare July 25, 2023 12:53
@Nurkambay Nurkambay force-pushed the feat-diagnostic branch 4 times, most recently from b97288c to ddfa4dc Compare July 26, 2023 11:04
@Nurkambay Nurkambay merged commit 28631ab into eclipse-che4z:development Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copybooks with Errors Continue Showing the Diagnostics After Removing the Statements
3 participants