Skip to content

fix: Skip analysis for not used copybook #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

Nurkambay
Copy link
Contributor

@Nurkambay Nurkambay commented Jul 27, 2023

How Has This Been Tested?

  • Test A
  1. Open program A that refers to copybook A
  2. Open 'copybook A' and add an error
  3. Ensure that program A was reanalyzed
  4. Create a new COBOL file
  5. Modify the new COBOL file
  6. Ensure program A was not analyzed
  • Test B
  1. Open program A that refers to copybook A
  2. Open program B that refers to copybook B
  3. Open program C that refers to copybook A and copybook B
  4. Open 'copybook A' and add an error
  5. Ensure that program A and program C was reanalyzed
  6. Ensure that program B was not reanalyzed
  • Test C
  1. Open program D that refers to copybook D
  2. Open copybook D that refers to copybook A
  3. Open copybook A and add an error
  4. Ensure that program A was reanalyzed
  5. Ensure that program A, copybook D and copybook A have errors

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Nurkambay Nurkambay force-pushed the fix-trigger-analysis branch from 7716828 to 0893a23 Compare July 28, 2023 09:46
@Nurkambay Nurkambay force-pushed the fix-trigger-analysis branch from 0893a23 to 4c905e1 Compare July 28, 2023 12:48
@Nurkambay Nurkambay force-pushed the fix-trigger-analysis branch 2 times, most recently from 9ccb9c3 to c398019 Compare July 29, 2023 11:01
@Nurkambay Nurkambay requested a review from ishche July 31, 2023 08:27
@Nurkambay Nurkambay marked this pull request as ready for review July 31, 2023 08:32
@Nurkambay Nurkambay force-pushed the fix-trigger-analysis branch from c398019 to 14c3d4a Compare July 31, 2023 09:05
@Nurkambay Nurkambay merged commit cee3b08 into eclipse-che4z:development Jul 31, 2023
@Nurkambay Nurkambay deleted the fix-trigger-analysis branch July 31, 2023 12:48
ap891843 pushed a commit that referenced this pull request Mar 14, 2025
fix: Skip analysis for not used copybook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants