fix: Fix NPE and add a message #2111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nurkambay
commented
Oct 19, 2023
| .map(CobolDocumentModel::getAnalysisResult) | ||
| .map(AnalysisResult::getRootNode).orElseGet(() -> { | ||
| if (isCopybook(uri, text)) { | ||
| communications.notifyGeneralMessage(MessageType.Info, "Cannot retrieve outline tree because file was treated as a copybook"); |
There was a problem hiding this comment.
@zeibura please check this message
It will appear as a VSCode info box when a user tries to generate a graph from CCF for the copybook. Sometimes some COBOL programs are treated as a copybook and the user has the ability to try to build a graph and this message is to inform the user that it is not possible.
Nurkambay
commented
Oct 19, 2023
| @@ -30,7 +30,7 @@ public class CopybookIdentificationServiceBasedOnContent implements CopybookIden | |||
| private final List<Pattern> patterns = new LinkedList<>(); | |||
| public CopybookIdentificationServiceBasedOnContent() { | |||
| patterns.add(Pattern.compile( | |||
| "(?i)^(?<sequence>.{0,6})(?<indicator>.?)\\s(?<!\\n)*(PROGRAM-ID)\\s*\\.?\\s*(?<programName>.{1,30})\\s*\\.?$", | |||
| "(?i)^(?<sequence>.{0,6})(?<indicator>.?)\\h*(PROGRAM-ID)\\s*\\.?\\s*(?<programName>.{1,30})\\s*\\.?$", | |||
There was a problem hiding this comment.
Simplification. Use \h instead of s(?<!\\n)
ishche
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: