Skip to content

Feature/e4e/copybooks #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 18, 2024
Merged

Feature/e4e/copybooks #2302

merged 11 commits into from
Jun 18, 2024

Conversation

KutluOzel-b
Copy link
Contributor

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

slavek-kucera
slavek-kucera reviewed May 16, 2024
View reviewed changes
slavek-kucera
slavek-kucera reviewed May 20, 2024
View reviewed changes
@slavek-kucera
Copy link
Contributor

CopybookDownloadService.downloadCopybooks probably needs to be updated.

slavek-kucera
slavek-kucera reviewed May 29, 2024
View reviewed changes
...code-extension/src/__tests__/services/copybook/download/DownloadStrategyResolverTest.spec.ts
(downloader as any).ussDownloader.downloadCopybook = jest
.fn()
.mockReturnValue(false);
(E4ECopybookService as any).getE4EClient = jest.fn().mockReturnValue({});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition indicates that it should not resolve - the copybook is not there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, it indicates that It is not relevant to e4e

@KutluOzel-b KutluOzel-b force-pushed the feature/e4e/copybooks branch from 7f814d1 to 68b243a Compare June 4, 2024 14:01
@KutluOzel-b KutluOzel-b marked this pull request as ready for review June 4, 2024 14:55
slavek-kucera
slavek-kucera approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@slavek-kucera slavek-kucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still not happy about the static E4EConfigs, but I guess we can deal with it later...

@ishche
Copy link
Contributor

ishche commented Jun 11, 2024

Please resolve conflicts and squash commits.

@slavek-kucera slavek-kucera merged commit f513a14 into eclipse-che4z:development Jun 18, 2024
17 checks passed
ap891843 pushed a commit that referenced this pull request Mar 14, 2025
@KutluOzel-b
feat: Support downloading copybooks from Endevor (#2302)
04fede5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavek-kucera slavek-kucera slavek-kucera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KutluOzel-b @slavek-kucera @ishche