Skip to content

feat: Uppercase/Lowercase All Non-literal Tokens With Formatting #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

Nurkambay
Copy link
Contributor

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ishche
Copy link
Contributor

ishche commented Oct 24, 2024

Since program id has not been changed, should we preserve program calls?

@Nurkambay Nurkambay requested a review from ishche October 25, 2024 08:21
@Nurkambay Nurkambay force-pushed the uppercase-formatting branch from f3d1ea4 to 6a5a60b Compare October 25, 2024 08:23
@Nurkambay Nurkambay requested a review from VitGottwald October 25, 2024 08:23
@Nurkambay
Copy link
Contributor Author

Since program id has not been changed, should we preserve program calls?

What do you mean?

@ishche
Copy link
Contributor

ishche commented Oct 25, 2024

Since program id has not been changed, should we preserve program calls?

Seems that it's not the case, because cobol expects program names as literals.

@Nurkambay Nurkambay merged commit 5f71288 into eclipse-che4z:development Oct 25, 2024
18 checks passed
@Nurkambay Nurkambay deleted the uppercase-formatting branch October 25, 2024 10:54
ap891843 pushed a commit that referenced this pull request Mar 14, 2025
* feat: Uppercase/Lowercase All Non-literal Tokens In The Document With Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capitalize All Non-literal Tokens In The Document With Formatting
4 participants