Skip to content

feat: Provide LSPConfig overrides #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

slavek-kucera
Copy link
Contributor

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@slavek-kucera slavek-kucera force-pushed the feat_lspconfig_compiler_override branch from e3b4aaa to ade2e84 Compare November 15, 2024 14:39
@slavek-kucera slavek-kucera marked this pull request as ready for review January 9, 2025 12:36
Comment on lines +542 to +548
"cobol-lsp.lspconfig.preprocessors": {
"type": "array",
"items": {
"type": "string"
},
"description": "List of preprocessors used by the LSPConfig",
"uniqueItems": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has no impact on actual language server processing today, I think we may postpone defining it here and keep it as a hidden option.

@slavek-kucera slavek-kucera merged commit 02e41e1 into development Jan 10, 2025
18 checks passed
@slavek-kucera slavek-kucera deleted the feat_lspconfig_compiler_override branch January 10, 2025 15:43
ap891843 pushed a commit that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants