Cics ROUTE improvements #2626
Merged
Cics ROUTE improvements #2626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chacebot
reviewed
Dec 10, 2024
server/engine/src/main/antlr4/org/eclipse/lsp/cobol/implicitDialects/cics/CICSParser.g4
Outdated
Show resolved
Hide resolved
chacebot
reviewed
Dec 10, 2024
server/engine/src/main/antlr4/org/eclipse/lsp/cobol/implicitDialects/cics/CICSParser.g4
Outdated
Show resolved
Hide resolved
Added checks for grammar, tied to optionsMap, added support function where one or more rules must be present.
mm-broadcom
force-pushed
the
CICS-ROUTE-Improvements
branch
from
e620e71 to
d0b2fa9
Compare
...n/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSRouteOptionsCheckUtility.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSOptionsCheckBaseUtility.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSOptionsCheckBaseUtility.java
Outdated
Show resolved
Hide resolved
server/engine/src/main/antlr4/org/eclipse/lsp/cobol/implicitDialects/cics/CICSParser.g4
Show resolved
Hide resolved
...in/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSOptionsCheckBaseUtility.java
Outdated
Show resolved
Hide resolved
...in/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSOptionsCheckBaseUtility.java
Outdated
Show resolved
Hide resolved
...n/java/org/eclipse/lsp/cobol/implicitDialects/cics/utility/CICSRouteOptionsCheckUtility.java
Outdated
Show resolved
Hide resolved
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases/TestCicsRouteStatement.java
Outdated
Show resolved
Hide resolved
…ects/cics/utility/CICSOptionsCheckBaseUtility.java Co-authored-by: slavek-kucera <[email protected]>
…ects/cics/utility/CICSRouteOptionsCheckUtility.java Co-authored-by: slavek-kucera <[email protected]>
slavek-kucera
approved these changes
Jan 17, 2025
ap891843
pushed a commit
that referenced
this pull request
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
Implemented tests for both valid and invalid use case(s).
Checklist: