Skip to content

fix: Fix CFAST json representation #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

Nurkambay
Copy link
Contributor

Eclipse library treat Enum as a number instead of string, that's why tests are passing, but actual CFAST coming from COBOL LS contains numbers instead of Enum names

Checklist:

  • Each of my commits contains one meaningful change
  • I have performed rebase of my branch on top of the development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@Nurkambay Nurkambay force-pushed the fix-tiny branch 3 times, most recently from 3eb28e1 to 007747b Compare January 15, 2025 16:50
Copy link
Contributor

@slavek-kucera slavek-kucera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SerializedName might be worth looking into.

@Nurkambay Nurkambay merged commit ce9cdc4 into eclipse-che4z:development Jan 15, 2025
18 checks passed
@Nurkambay Nurkambay deleted the fix-tiny branch January 15, 2025 17:15
ap891843 pushed a commit that referenced this pull request Mar 14, 2025
* fix: Fix CFAST json representation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants