Skip to content

Hardcoded URLs break local builds #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
atextor opened this issue Jan 10, 2024 · 1 comment
Open

Hardcoded URLs break local builds #16

atextor opened this issue Jan 10, 2024 · 1 comment
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps.

Comments

@atextor
Copy link
Contributor

atextor commented Jan 10, 2024

In the new UI, in particular in the dropdowns, there are many URLs hardcoded with "http://eclipse-esmf.github.io/..." instead of using relative links. This means those menus do not work as intended when doing a local build using a site-local.yml.

@chris-volk chris-volk added the acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps. label Feb 1, 2024
@aniluede
Copy link
Contributor

aniluede commented Apr 5, 2024

As for the dropdowns of the top navigation: the links indeed are hardcoded as they are defined in the corresponding HBS source file of the UI Bundle the page uses for its layout. Referring to these files:

I don't see how the links there could be XREFs.

However, the tiles of the landing page -- which are defined here: https://github.com/eclipse-esmf/eclipse-esmf.github.io/blob/main/documentation/modules/ROOT/pages/index.adoc?plain=1 -- do hold relative links. They can be used to jump around in local builds.

And also, in the index.adoc file linked above -- at the moment we introduce HTML, for example to specify a button, we are back to hardcoded URLs instead of XREFs.

--

Proposing to close this issue as "Won't fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledged Has been viewed by one of the maintainers and is ready for further work, discussion or other steps.
Projects
None yet
Development

No branches or pull requests

3 participants