Skip to content

Commit 2008d20

Browse files
authored
Merge pull request #2512 from AlenBadel/mute
Limiting Trace Logging by P Codegen
2 parents 9f239b8 + 6f1f6b6 commit 2008d20

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

runtime/compiler/codegen/J9CodeGenerator.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2766,13 +2766,13 @@ J9::CodeGenerator::compressedReferenceRematerialization()
27662766
}
27672767

27682768
// no need to rematerialize for lowMemHeap
2769-
//
27702769
if (self()->comp()->useCompressedPointers() &&
27712770
((TR::Compiler->vm.heapBaseAddress() != 0) ||
27722771
(TR::Compiler->om.compressedReferenceShift() != 0)) &&
27732772
!disableRematforCP)
27742773
{
2775-
self()->comp()->dumpMethodTrees("Trees before this remat phase", self()->comp()->getMethodSymbol());
2774+
if (self()->comp()->getOption(TR_TraceCG))
2775+
self()->comp()->dumpMethodTrees("Trees before this remat phase", self()->comp()->getMethodSymbol());
27762776

27772777
List<TR::Node> rematerializedNodes(self()->trMemory());
27782778
vcount_t visitCount = self()->comp()->incVisitCount();
@@ -2866,8 +2866,8 @@ J9::CodeGenerator::compressedReferenceRematerialization()
28662866
rematerializedNodes.deleteAll();
28672867
}
28682868
}
2869-
2870-
self()->comp()->dumpMethodTrees("Trees after this remat phase", self()->comp()->getMethodSymbol());
2869+
if (self()->comp()->getOption(TR_TraceCG))
2870+
self()->comp()->dumpMethodTrees("Trees after this remat phase", self()->comp()->getMethodSymbol());
28712871

28722872
if (self()->shouldYankCompressedRefs())
28732873
{
@@ -2881,7 +2881,8 @@ J9::CodeGenerator::compressedReferenceRematerialization()
28812881
self()->yankCompressedRefs(tt, NULL, -1, node, visitCount, secondVisitCount);
28822882
}
28832883

2884-
self()->comp()->dumpMethodTrees("Trees after this yank phase", self()->comp()->getMethodSymbol());
2884+
if (self()->comp()->getOption(TR_TraceCG))
2885+
self()->comp()->dumpMethodTrees("Trees after this yank phase", self()->comp()->getMethodSymbol());
28852886
}
28862887
}
28872888

runtime/compiler/codegen/J9TreeEvaluator.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,8 @@ uint32_t J9::TreeEvaluator::calculateInstanceOfOrCheckCastSequences(TR::Node *in
243243
//
244244
else if (castClassSymRef->isUnresolved())
245245
{
246-
traceMsg(cg->comp(),"Cast Class unresolved\n");
246+
if (cg->comp()->getOption(TR_TraceCG))
247+
traceMsg(cg->comp(),"Cast Class unresolved\n");
247248
if (mayBeNull)
248249
sequences[i++] = NullTest;
249250
sequences[i++] = ClassEqualityTest;

runtime/compiler/p/codegen/PPCPrivateLinkage.cpp

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*******************************************************************************
2-
* Copyright (c) 2000, 2017 IBM Corp. and others
2+
* Copyright (c) 2000, 2018 IBM Corp. and others
33
*
44
* This program and the accompanying materials are made available under
55
* the terms of the Eclipse Public License 2.0 which accompanies this
@@ -945,8 +945,8 @@ static int32_t calculateFrameSize(TR::RealRegister::RegNum &intSavedFirst,
945945
comp->failCompilation<TR::CompilationInterrupted>("Overflowed or underflowed bounds of regSaveOffset in calculateFrameSize.");
946946
}
947947

948-
//pramod
949-
traceMsg(comp, "PPCLinkage calculateFrameSize registerSaveDescription: 0x%x regSaveOffset: %x\n", registerSaveDescription, regSaveOffset);
948+
if (cg->comp()->getOption(TR_TraceCG))
949+
traceMsg(comp, "PPCLinkage calculateFrameSize registerSaveDescription: 0x%x regSaveOffset: %x\n", registerSaveDescription, regSaveOffset);
950950
registerSaveDescription |= (regSaveOffset << 17); // see above for details
951951
cg->setFrameSizeInBytes(size+firstLocalOffset);
952952
TR_ASSERT((size-argSize+firstLocalOffset)<2048*1024, "Descriptor overflowed.\n");
@@ -2074,11 +2074,9 @@ int32_t TR::PPCPrivateLinkage::buildPrivateLinkageArgs(TR::Node
20742074
}
20752075
}
20762076
}
2077-
else
2078-
{
2077+
else if (cg()->comp()->getOption(TR_TraceCG))
20792078
traceMsg(comp(), "Omitting CCR save/restore for helper calls\n");
2080-
}
2081-
2079+
20822080
if (memArgs > 0)
20832081
{
20842082
for (argIndex = 0; argIndex < memArgs; argIndex++)

0 commit comments

Comments
 (0)