Fix io.popen() with mode parameter

Author: edubart

lib/io.nelua

@@ -97,7 +97,7 @@ function io.popen(prog: string, mode: facultative(string)) : (filestream, string
   ## if mode.type.is_niltype then
   local mode: string = "r"
   ## else
-  assert(m.size == 1 and (m.data[0] == 'r' or m.data[0] == 'w') and m.data[1] == '\0', 'invalid mode')
+  assert(mode.size == 1 and (mode.data[0] == 'r'_b or mode.data[0] == 'w'_b) and mode.data[1] == 0, 'invalid mode')
   ## end
   ## if ccinfo.is_wasm then
   return filestream{}, 'unsupported', -1

tests/io_test.nelua

@@ -42,16 +42,31 @@ do -- basic io.open/io.isopen/io.close
 end
 
 do -- io.popen
-  local file = io.popen('echo test')
-  ## if ccinfo.is_linux then
-  assert(file:isopen())
-  ## end
-  if file:isopen() then
-    local s = file:read('a')
-    assert(s == 'test\n')
-    s:destroy()
-    file:close()
-    file:destroy()
+  do
+    local file = io.popen('echo test')
+    ## if ccinfo.is_linux then
+    assert(file:isopen())
+    ## end
+    if file:isopen() then
+      local s = file:read('a')
+      assert(s == 'test\n')
+      s:destroy()
+      file:close()
+      file:destroy()
+    end
+  end
+  do
+    local file = io.popen('echo test', 'r')
+    ## if ccinfo.is_linux then
+    assert(file:isopen())
+    ## end
+    if file:isopen() then
+      local s = file:read('a')
+      assert(s == 'test\n')
+      s:destroy()
+      file:close()
+      file:destroy()
+    end
   end
 end