Skip to content

Commit 0e6f868

Browse files
committed
Disabled tslint rule : mgechev/codelyzer#191 for false positive.
Fixed tslint errors.
1 parent d95488d commit 0e6f868

19 files changed

+28
-30
lines changed

src/client/app/authentication/components/password/restore-password.component.html

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<!-- template -->
22

3-
Restoring password for : {{form.username}}
4-
Confirmation token : {{form.lostPasswordToken}}
3+
Restoring password for : {{ form.username }}
4+
Confirmation token : {{ form.lostPasswordToken }}
55

66
<sd-error-box [error]="error"></sd-error-box>
77

src/client/app/authentication/components/signin/facebook-social-signin-button.component.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class FacebookSocialSigninButtonComponent {
2020

2121
getLink() : string {
2222
let tid = this._tenantResolverService.resolveCurrentTenant();
23-
return this._signinService.socialProviderLinks.facebook + '?tenant=' + tid;
23+
return this._signinService.socialProviderLinks.facebook + '?tenant=' + tid;
2424
}
25-
25+
2626
}

src/client/app/authentication/components/signin/google-social-signin-button.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ export class GoogleSocialSigninButtonComponent {
2020

2121
getLink() : string {
2222
let tid = this._tenantResolverService.resolveCurrentTenant();
23-
return this._signinService.socialProviderLinks.google + '?tenant=' + tid;
23+
return this._signinService.socialProviderLinks.google + '?tenant=' + tid;
2424
}
2525
}
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
Activation in process...
22

3-
Account confirmed : {{accountConfirmed}}
3+
Account confirmed : {{ accountConfirmed }}

src/client/app/home/components/home.component.html

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ <h1>Test JIG</h1>
1111

1212
<md-card>
1313
<md-card-title>Websocket test (will become eventually a directive for chat / one for push notifications</md-card-title>
14-
<md-card-subtitle>CHAT-WEBSOCKET status: {{status}}</md-card-subtitle>
14+
<md-card-subtitle>CHAT-WEBSOCKET status: {{ status }}</md-card-subtitle>
1515
<md-card-content>
1616
<form (submit)="sendChat()" *ngIf="status == 'ONLINE'">
1717
<input [(ngModel)]="chatMessage" [ngModelOptions]="{standalone: true}" placeholder="Enter your message!" (keypress)="enableTypingAction()">
@@ -29,7 +29,7 @@ <h1>Test JIG</h1>
2929
</div>
3030

3131
<md-list dense style="margin-top: 10px;">
32-
<md-list-item *ngFor="let chatmsgs of displayChatMessages()"><div>{{chatmsgs}}</div></md-list-item>
32+
<md-list-item *ngFor="let chatmsgs of displayChatMessages()"><div>{{ chatmsgs }}</div></md-list-item>
3333
</md-list>
3434
</md-card-content>
3535
</md-card>
@@ -39,7 +39,7 @@ <h1>Test JIG</h1>
3939
<md-card-title>Forms components</md-card-title>
4040
<md-card-content>
4141
<b>Image upload</b>
42-
<div>Url: {{docBackendApi}}</div>
42+
<div>Url: {{ docBackendApi }}</div>
4343
<div style="margin-top: 10px;">
4444
<div><b>Single file upload:</b></div>
4545
<sd-file-upload [uploadUrl]="docBackendApi" uploaderType="singlefile" maxSizeKb="500" fileTypes="*" [subscriber]="fileuploadSub"></sd-file-upload>

src/client/app/profile/components/profile.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Component} from '@angular/core';
1+
import { Component } from '@angular/core';
22

33
import { ManagedComponent, IFileUploadResultsSubscriber, LoggerService } from '../../shared/index';
44

src/client/app/profile/services/profile.service.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { Injectable} from '@angular/core';
1+
import { Injectable } from '@angular/core';
22

33
import { IApiResult, HttpRestService, AuthTokenService, EventService, ProfileLiteRefreshEvent, HttpUrlUtils } from '../../shared/index';
44

@@ -28,7 +28,8 @@ export class ProfileService {
2828
updateProfile(form : ProfileForm) : IApiResult<Profile> {
2929
let userId = this._authTokenService.currentUserId();
3030
let payload = new Profile(userId, form.firstName, form.lastName, form.gender, form.birthday, form.avatarUrl);
31-
let apiResult = this._httpRestService.httpPut<Profile>(HttpUrlUtils.combineId('<%= BACKEND_API.ACCOUNTSERVICE_API_updateProfile %>', payload.userId), payload);
31+
let apiResult = this._httpRestService.httpPut<Profile>(
32+
HttpUrlUtils.combineId('<%= BACKEND_API.ACCOUNTSERVICE_API_updateProfile %>', payload.userId), payload);
3233
this._addProfileUpdatedInterceptor(apiResult);
3334
return apiResult;
3435
}
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<div *ngIf="errorMessage" style="display: inline-block; margin-top: 20px;" align="center">
22
<md-card>
3-
<span style="color:red;"><md-icon>error</md-icon>{{errorMessage}}</span>
3+
<span style="color:red;"><md-icon>error</md-icon>{{ errorMessage }}</span>
44
</md-card>
55
</div>

src/client/app/shared/components/error/error-box.component.ts

-2
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ export class ErrorBoxComponent {
1616

1717
errorMessage : string;
1818

19-
constructor() {}
20-
2119
@Input()
2220
set error(apiError: ApiError) {
2321
if (apiError) {

src/client/app/shared/components/forms/auto-complete/auto-complete-input.component.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { Component, Injectable, Input } from '@angular/core';
2-
import {CompleterItem } from 'ng2-completer';
2+
import { CompleterItem } from 'ng2-completer';
33

44
import { AutoCompleteDataProviderService } from '../../../services/forms/auto-complete/auto-complete-data-provider.service';
55

src/client/app/shared/components/forms/file-upload/form-file-upload.component.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,5 @@
4242

4343
<!-- Errors -->
4444
<div *ngFor="let error of errorMessages">
45-
<span *ngIf="error" style="color:red;">{{error}}</span>
45+
<span *ngIf="error" style="color:red;">{{ error }}</span>
4646
</div>

src/client/app/shared/components/forms/form-field-error-label.component.ts

-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ export class FormFieldErrorLabelComponent implements OnDestroy {
2121

2222
private _sub : any;
2323

24-
constructor() {}
25-
2624
@Input()
2725
set form(baseForm: BaseForm) {
2826
this.baseForm = baseForm;

src/client/app/shared/components/forms/form-submit-button.component.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import {Component, Injectable, Input} from '@angular/core';
1+
import { Component, Injectable, Input } from '@angular/core';
22

3-
import {ManagedComponent} from '../../index';
3+
import { ManagedComponent } from '../../index';
44

55

66
@Component({

src/client/app/shared/services/forms/auto-complete/auto-complete-data-provider.service.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
1-
import {Subject} from 'rxjs/Subject';
2-
import {Injectable} from '@angular/core';
3-
import {Headers} from '@angular/http';
4-
import {CompleterData, CompleterItem} from 'ng2-completer';
1+
import { Subject } from 'rxjs/Subject';
2+
import { Injectable } from '@angular/core';
3+
import { Headers } from '@angular/http';
4+
import { CompleterData, CompleterItem } from 'ng2-completer';
55

6-
import {BaseModel, ApiError, LoggerService, HttpRestService, HttpConstants, SearchResults} from '../../../index';
6+
import { BaseModel, ApiError, LoggerService, HttpRestService, HttpConstants, SearchResults } from '../../../index';
77

88
@Injectable()
99
export class AutoCompleteDataProviderService extends Subject<CompleterItem[]> implements CompleterData {

src/client/app/shared/services/logger/logger.service.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export function main() {
7373
loggerService.info(message, [':-)', [1,2,3,'YO']]);
7474
expect(console.info).toHaveBeenCalled();
7575
let logStr = <string>(spy.calls.mostRecent().args[0]);
76-
let logged = logStr.substring(logStr.indexOf('INFO -') + 7, logStr.length)
76+
let logged = logStr.substring(logStr.indexOf('INFO -') + 7, logStr.length);
7777
expect(logged).toBe(expected);
7878
});
7979
});

src/client/app/shared/services/websocket/websocket.service.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export function main() {
2727
beforeEach(() => {
2828
// weird bug that displays a Karma warning for missing css. It should not happen as this is a service, not component
2929
// maybe the service is loading a component (when it should not)
30-
document.body.insertAdjacentHTML('afterbegin', '<link rel=\"stylesheet\" href=\"/base/dist/dev/css/indigo-pink.css\" />')
30+
document.body.insertAdjacentHTML('afterbegin', '<link rel=\"stylesheet\" href=\"/base/dist/dev/css/indigo-pink.css\" />');
3131

3232
mockedAuthTokenService = new MockedAuthTokenService(null, mockedLoggerService);
3333
serviceUnderTest = new WebsocketService(mockedLoggerService, mockedAuthTokenService);

src/client/app/shared/toolbar/toolbar.component.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<div *ngIf="isAuthenticated">
22
<md-icon>lock</md-icon>
3-
Welcome: {{profileLite?.firstName + ' ' + profileLite?.lastName}}
3+
Welcome: {{ profileLite?.firstName + ' ' + profileLite?.lastName }}
44

55
<img [src]="profileLite?.avatarUrl" height="25" width="25"/>
66

src/client/testing/models/base-model-test-utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export namespace BaseModelTestUtils {
3131
result.message = `Expected ${input.bindingClassName} to be ` +
3232
`registered as ${input.targetClass}, but it was not`;
3333
}
34-
34+
3535
return result;
3636
}
3737
})

tslint.json

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"extends": "./tools/config/seed.tslint.json",
33
"rules": {
4+
"no-access-missing-member": false
45
}
56
}

0 commit comments

Comments
 (0)