Skip to content

fixed #342 #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fixed #342 #399

wants to merge 1 commit into from

Conversation

Saksham1387
Copy link

@Saksham1387 Saksham1387 commented Apr 8, 2025 •
edited by coderabbitai bot
Loading

Fixes #342

Screenshot 2025-04-08 at 22 50 03

Summary by CodeRabbit

  • New Features
    • Enhanced the pricing experience by integrating session data for potential personalized content.
    • Introduced an Azure sign-in option in the login process, offering a clear, consent-based authentication flow.
    • Improved the email interface’s responsiveness, adapting the layout and navigation controls for mobile devices.
    • Expanded authentication support to include Azure Active Directory.

@vercel Vercel
Copy link

vercel bot commented Apr 8, 2025

@Saksham1387 is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Saksham1387 Saksham1387 closed this Apr 8, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 8, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several feature enhancements and UI improvements. The pricing component now accesses session data via the useSession hook. The login form adds an Azure sign-in dialog preceding the Google option, and the authentication utility is updated to include an Azure AD provider. Additionally, responsive improvements are applied to the email list and panel components through a new mobile-detection hook that conditionally renders UI elements on mobile devices.

Changes

File(s) Change Summary
apps/web/app/(app)/premium/Pricing.tsx Added a call to useSession after destructuring usePremium to incorporate session data into the Pricing component.
apps/web/app/(landing)/login/LoginForm.tsx Introduced a new Azure sign-in dialog component (with button, header, description, and error handling) that triggers signIn with provider "azure-ad" before the Google sign-in dialog.
apps/web/components/email-list/EmailList.tsx
apps/web/components/email-list/EmailPanel.tsx		 Implemented a new useIsMobile hook for viewport detection; updated the EmailList to conditionally render panels and the EmailPanel to show a mobile-specific back button (using ArrowLeftIcon), replacing the default close button on mobile views.
apps/web/utils/auth.ts Added the AzureADProvider to the authentication options, configured using environment variables for client credentials.

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant LoginForm
    participant Dialog
    participant AuthUtility
    participant AzureADProvider

    User->>LoginForm: Click "Sign in with azure" button
    LoginForm->>Dialog: Open Azure sign-in dialog
    User->>Dialog: Click "I agree"
    Dialog->>LoginForm: Trigger signIn("azure-ad")
    LoginForm->>AuthUtility: Request authentication with "azure-ad"
    AuthUtility->>AzureADProvider: Process Azure AD authentication request
    AzureADProvider-->>AuthUtility: Return authentication result
    AuthUtility-->>LoginForm: Deliver auth response
Loading

Assessment against linked issues

Objective Addressed Explanation
Ensure email components display in full-screen mode on mobile rather than in split view (#342: mobile support) ✅ EmailList and EmailPanel now conditionally render views based on mobile detection.

Poem

I'm a rabbit with a hop so light,
Session data now makes my code shine bright.
Azure sign-in hops right into the flow,
Mobile tweaks let full-screen magic show,
Hopping through changes with delight!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/app/(app)/premium/Pricing.tsx

Oops! Something went wrong! :(

ESLint: 9.23.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

apps/web/app/(landing)/login/LoginForm.tsx

Oops! Something went wrong! :(

ESLint: 9.23.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

apps/web/components/email-list/EmailPanel.tsx

Oops! Something went wrong! :(

ESLint: 9.23.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

  • 2 others
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 048124a and 987bc3f.

📒 Files selected for processing (5)
  • apps/web/app/(app)/premium/Pricing.tsx (1 hunks)
  • apps/web/app/(landing)/login/LoginForm.tsx (1 hunks)
  • apps/web/components/email-list/EmailList.tsx (5 hunks)
  • apps/web/components/email-list/EmailPanel.tsx (4 hunks)
  • apps/web/utils/auth.ts (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Saksham1387 Saksham1387 deleted the feat/mobile-fullscreen branch April 8, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reply Zero + Mail: mobile support
2 participants
@Saksham1387 @CLAassistant