You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix(ses-demo): adapt to disabled Date.now() throwing (#2357)
Closes: #XXXX
Refs: #910 (comment)#1718#2354#910
## Description
While investigating #2354 , I just
tried it locally by visiting
file:///.../endojs/endo/packages/ses/demos/console/index.html
and
file:///.../endojs/endo/packages/ses/demos/challenge/index.html
in my browser. The first is the SES demo console, which worked just
fine. The second is the SES Escape Room, which still relied on the
disabled `Date.now()` not throwing. Indeed, before
#1718 a disabled (secure mode)
`Date.now()` returned `NaN`. But
#1718 changed it to throw.
What's strange is that in #1718 I
revise endojs/endo/packages/ses/demos/challenge/index.html to adjust the
text to say that `Date.now()` is "disabled" rather than "NaN". But I
didn't fix the escape room code.
Although I found this while investigating
#2354 , this is a completely
distinct bug that is unrelated to
#2354 . This PR itself does nothing
to fix#2354 .
### Security Considerations
none
### Scaling Considerations
none
### Documentation Considerations
All our docs that link to an explain the Escape Room challenge need to
be revisited, especially once #2354
is fixed. For example,
https://agoric.com/blog/technology/a-taxonomy-of-security-issues , which
I just verified links to the broken page reported at
#2354
### Testing Considerations
It is frustrating that the Escape Room is broken at least since
#1718 , and also broken by
#2354 for an undetermined period of
time, without anyone noticing until now. It would be good to bring that
site under some kind of automated testing.
### Compatibility Considerations
none
### Upgrade Considerations
none
0 commit comments