feat: add supported features to gateway class

Signed-off-by: Kobi Levi <[email protected]>

Author: levikobi

internal/cmd/egctl/translate.go

@@ -274,11 +274,13 @@ func translateGatewayAPIToGatewayAPI(resources *gatewayapi.Resources) (gatewayap
 			epInvalid = true
 			msg := fmt.Sprintf("%s: %v", status.MsgGatewayClassInvalidParams, err)
 			status.SetGatewayClassAccepted(resources.GatewayClass, false, string(gwapiv1.GatewayClassReasonInvalidParameters), msg)
+			status.SetGatewayClassSupportedFeatures(resources.GatewayClass)
 		}
 		gRes.EnvoyProxy = resources.EnvoyProxy
 	}
 	if !epInvalid {
 		status.SetGatewayClassAccepted(resources.GatewayClass, true, string(gwapiv1.GatewayClassReasonAccepted), status.MsgValidGatewayClass)
+		status.SetGatewayClassSupportedFeatures(resources.GatewayClass)
 	}
 
 	gRes.GatewayClass = resources.GatewayClass

internal/provider/kubernetes/controller.go

@@ -501,12 +501,14 @@ func (r *gatewayAPIReconciler) gatewayClassUpdater(ctx context.Context, gc *gwap
 					panic(fmt.Sprintf("unsupported object type %T", obj))
 				}
 
-				return status.SetGatewayClassAccepted(gc.DeepCopy(), accepted, reason, msg)
+				gc = status.SetGatewayClassAccepted(gc.DeepCopy(), accepted, reason, msg)
+				return status.SetGatewayClassSupportedFeatures(gc.DeepCopy())
 			}),
 		})
 	} else {
 		// this branch makes testing easier by not going through the status.Updater.
 		duplicate := status.SetGatewayClassAccepted(gc.DeepCopy(), accepted, reason, msg)
+		duplicate = status.SetGatewayClassSupportedFeatures(duplicate.DeepCopy())
 
 		if err := r.client.Status().Update(ctx, duplicate); err != nil && !kerrors.IsNotFound(err) {
 			return fmt.Errorf("error updating status of gatewayclass %s: %w", duplicate.Name, err)

internal/provider/kubernetes/controller_test.go

@@ -21,6 +21,7 @@ import (
 	"github.com/envoyproxy/gateway/internal/envoygateway/config"
 	"github.com/envoyproxy/gateway/internal/gatewayapi"
 	"github.com/envoyproxy/gateway/internal/logging"
+	"github.com/envoyproxy/gateway/internal/status"
 )
 
 func TestAddGatewayClassFinalizer(t *testing.T) {
@@ -189,6 +190,7 @@ func TestHasManagedClass(t *testing.T) {
 								Status: metav1.ConditionTrue,
 							},
 						},
+						SupportedFeatures: status.GetSupportedFeatures(),
 					},
 				},
 			},
@@ -223,6 +225,7 @@ func TestHasManagedClass(t *testing.T) {
 								Status: metav1.ConditionTrue,
 							},
 						},
+						SupportedFeatures: status.GetSupportedFeatures(),
 					},
 				},
 			},
@@ -275,6 +278,7 @@ func TestHasManagedClass(t *testing.T) {
 								Status: metav1.ConditionTrue,
 							},
 						},
+						SupportedFeatures: status.GetSupportedFeatures(),
 					},
 				},
 				{
@@ -297,6 +301,7 @@ func TestHasManagedClass(t *testing.T) {
 								Status: metav1.ConditionFalse,
 							},
 						},
+						SupportedFeatures: status.GetSupportedFeatures(),
 					},
 				},
 			},

internal/status/gatewayclass.go

@@ -14,7 +14,9 @@
 package status
 
 import (
+	"k8s.io/apimachinery/pkg/util/sets"
 	gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"
+	"sigs.k8s.io/gateway-api/conformance/utils/suite"
 )
 
 // SetGatewayClassAccepted inserts or updates the Accepted condition
@@ -23,3 +25,25 @@ func SetGatewayClassAccepted(gc *gwapiv1.GatewayClass, accepted bool, reason, ms
 	gc.Status.Conditions = MergeConditions(gc.Status.Conditions, computeGatewayClassAcceptedCondition(gc, accepted, reason, msg))
 	return gc
 }
+
+// GetSupportedFeatures returns a list of supported Gateway-API features,
+// based on the running conformance tests suite.
+func GetSupportedFeatures() []gwapiv1.SupportedFeature {
+
+	// TODO(levikobi): This must be in sync with the cSuite supported features.
+	supportedFeatures := suite.AllFeatures
+	supportedFeatures.Delete(suite.MeshCoreFeatures.UnsortedList()...)
+
+	ret := sets.New[gwapiv1.SupportedFeature]()
+	for _, feature := range supportedFeatures.UnsortedList() {
+		ret.Insert(gwapiv1.SupportedFeature(feature))
+	}
+	return sets.List(ret)
+}
+
+// SetGatewayClassSupportedFeatures insert or updates the SupportedFeatures field
+// for the provided GatewayClass.
+func SetGatewayClassSupportedFeatures(gc *gwapiv1.GatewayClass) *gwapiv1.GatewayClass {
+	gc.Status.SupportedFeatures = GetSupportedFeatures()
+	return gc
+}