fix: proxy creation/deletion error handling in GatewayNamespace mode #5954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zirain <[email protected]>
|
cc @cnvergence |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5954 +/- ##
==========================================
+ Coverage 65.80% 65.84% +0.03%
==========================================
Files 217 217
Lines 36013 36016 +3
==========================================
+ Hits 23699 23715 +16
+ Misses 10834 10824 -10
+ Partials 1480 1477 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cnvergence
approved these changes
May 8, 2025
cnvergence
reviewed
May 8, 2025
internal/infrastructure/kubernetes/ratelimit/resource_provider.go
Outdated
Show resolved
Hide resolved
Signed-off-by: zirain <[email protected]>
cnvergence
reviewed
May 8, 2025
Signed-off-by: zirain <[email protected]>
cnvergence
reviewed
May 8, 2025
internal/infrastructure/kubernetes/proxy/resource_provider_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: zirain <[email protected]>
|
/retest |
zhaohuabing
approved these changes
May 8, 2025
melsal13
referenced
this pull request
in melsal13/gatewayPersonal
May 9, 2025
…(#5954) * fix: proxy creation/deletion error handling in GatewayNamespace mode Signed-off-by: zirain <[email protected]> * nit Signed-off-by: zirain <[email protected]> * nit Signed-off-by: zirain <[email protected]> * more nit Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: melsal13 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5952