Skip to content

Commit 79862d9

Browse files
daskyrkerda-botsherotreehujiahao-hjh
authored
fix: merge hotfixs to 1.5 (#2369)
* fix: hide email and label of member table (#2343) (#2346) Co-authored-by: sherotree <[email protected]> * feat: modify route about service analysis (#2342) (#2347) * feat: modiify route about service analysis * fix: route when click service monitoor menu Co-authored-by: sherotree <[email protected]> * fix: trace detail bgo back to transaction in service monitor (#2349) (#2350) Co-authored-by: sherotree <[email protected]> * fix(common): msp project detail display bug in orgCenter (#2351) (#2352) Co-authored-by: hujiahao-hjh <[email protected]> * Hotfix/select onchange (#2358) (#2359) * fix: select not trigger passed in onChange function * fix: update tag style in filter Co-authored-by: 随风 <[email protected]> Co-authored-by: erda-bot <[email protected]> Co-authored-by: sherotree <[email protected]> Co-authored-by: hujiahao-hjh <[email protected]>
1 parent 65be1ef commit 79862d9

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

shell/app/common/components/configurable-filter/index.scss

+3
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,8 @@
184184
.twt-tag-item {
185185
height: 20px;
186186
line-height: 20px;
187+
margin-left: 0;
188+
margin-right: 4px;
187189
}
188190

189191
.rc-virtual-list-holder-inner {
@@ -193,6 +195,7 @@
193195

194196
.ant-select-item {
195197
padding: 0;
198+
margin-right: 4px;
196199
background-color: transparent !important;
197200
}
198201

shell/app/common/components/render-form-item/index.tsx

+8-8
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ const RenderFormItem = ({
215215

216216
ItemComp = (
217217
<ClassWrapper>
218-
<SelectComp options={options} size={size} itemProps={itemProps} />
218+
<SelectComp options={options} size={size} {...itemProps} />
219219
</ClassWrapper>
220220
);
221221
action = i18n.t('common:select');
@@ -227,7 +227,7 @@ const RenderFormItem = ({
227227

228228
ItemComp = (
229229
<ClassWrapper>
230-
<TagsSelect options={options} size={size} itemProps={itemProps} />
230+
<TagsSelect options={options} size={size} {...itemProps} />
231231
</ClassWrapper>
232232
);
233233
action = i18n.t('common:select');
@@ -278,8 +278,8 @@ const RenderFormItem = ({
278278
break;
279279
case 'dateRange':
280280
ItemComp = (
281-
<ClassWrapper {...itemProps}>
282-
<DateRange />
281+
<ClassWrapper>
282+
<DateRange {...itemProps} />
283283
</ClassWrapper>
284284
);
285285
break;
@@ -381,11 +381,11 @@ interface SelectCompProps {
381381
value: Array<number | string>;
382382
onChange: (value: Array<number | string>) => void;
383383
itemProps: Obj;
384+
optionRender: (option: IOption) => JSX.Element;
384385
}
385386

386-
const SelectComp = ({ value, onChange, options, size, itemProps }: SelectCompProps) => {
387+
const SelectComp = ({ value, onChange, options, size, optionRender, ...restItemProps }: SelectCompProps) => {
387388
const fixOptions = options.filter?.((item: IOption) => item.fix) || [];
388-
const { optionRender, ...restItemProps } = itemProps;
389389
return (
390390
<Select
391391
{...restItemProps}
@@ -525,12 +525,12 @@ interface TagsSelectProps {
525525
itemProps: Obj;
526526
}
527527

528-
const TagsSelect = ({ size, options, value = [], onChange, itemProps }: TagsSelectProps) => {
528+
const TagsSelect = ({ size, options, value = [], onChange, ...restItemProps }: TagsSelectProps) => {
529529
const [open, setOpen] = React.useState(false);
530530

531531
return (
532532
<Select
533-
{...itemProps}
533+
{...restItemProps}
534534
value={value}
535535
onChange={onChange}
536536
className="erda-tags-select"

0 commit comments

Comments
 (0)