Hi @siyuanfoundation, I'd like to work on implementing this feature. I'll follow the gRPC resolver API changes to deprecate the Metadata usage in favor of Attributes.

Hi @siyuanfoundation

I just sent in a pr with the implementation in place.

/assign @amosehiguese

Thank you!

We should also have use the supported fields in tests like #19702

Yeah, I noticed the tests still uses the metadata field, so my first attempt was to introduce the new field and make it backward compatible.

However, now that you've mentioned the Metadata field should remain in the Endpoint, I will revert back to that only and handle the conversion process underneath. If this is fine, please signify.

Lastly, I will love to mention that creating a new Attribute with the attributes.New(k, v any) to be used in the gresolver.Address Attribute field, takes in a key and a value as opposed to a single "any" argument(i.e the metadata passed)

Would you say it's okay to use the up.Key for the key and the up.Endpoint.Metadata for the value?

link to #15145

Let's follow the same pattern as grpc-go: add Attributes *attributes.Attributes into Endpoint, and deprecate Metadata

We might also want to backport the fix to release-3.6, depending on the complexity of the change.

cc @dfawley please chime in in case we miss anything, thx

Let's follow the same pattern as grpc-go: add Attributes *attributes.Attributes into Endpoint, and deprecate Metadata

@ahrtr I had a PR open addressing that.
Do you want me reopen the pr?

Edited: I just realised you've aligned the resolver to use Endpoint.Addresses as opposed to the resolver.Address

Do you want me reopen the pr?

Yes, I think so. Please feel free to open the PR.

Yes, I think so. Please feel free to open the PR.

I will be sending a fresh pr to align the API accordingly in a jiffy.