small cleanups and documentation rewording throughout the changes

Author: jwasinger

core/txpool/legacypool/legacypool.go

@@ -1266,7 +1266,7 @@ func (pool *LegacyPool) runReorg(done chan struct{}, reset *txpoolResetRequest,
 			if pool.chainconfig.IsOsaka(reset.newHead.Number, reset.newHead.Time) && !pool.chainconfig.IsOsaka(reset.oldHead.Number, reset.oldHead.Time) {
 				var removeHashes []common.Hash
 				pool.all.Range(func(hash common.Hash, tx *types.Transaction) bool {
-					if tx.Gas() > 30_000_000 {
+					if tx.Gas() > params.MaxTxGas {
 						removeHashes = append(removeHashes, hash)
 					}
 					return true
@@ -1305,7 +1305,6 @@ func (pool *LegacyPool) runReorg(done chan struct{}, reset *txpoolResetRequest,
 				pendingBaseFee := eip1559.CalcBaseFee(pool.chainconfig, reset.newHead)
 				pool.priced.SetBaseFee(pendingBaseFee)
 			} else {
-				// condition can only occur in testing?
 				pool.priced.Reheap()
 			}
 		}

core/txpool/txpool.go

@@ -78,7 +78,7 @@ type TxPool struct {
 	sync chan chan error // Testing / simulator channel to block until internal reset is done
 
 	headLock sync.RWMutex
-	head     *types.Header // the head of the current pool state
+	head     *types.Header // this reflects the state from the latest pool reset
 }
 
 // New creates a new transaction pool to gather, sort and filter inbound

core/txpool/validation.go

@@ -87,7 +87,7 @@ func ValidateTransaction(tx *types.Transaction, head *types.Header, signer types
 		return fmt.Errorf("%w: code size %v, limit %v", core.ErrMaxInitCodeSizeExceeded, len(tx.Data()), params.MaxInitCodeSize)
 	}
 	if rules.IsOsaka && tx.Gas() > params.MaxTxGas {
-		return fmt.Errorf("transaction gas exceeded max allowed (30_000_000): %d", tx.Gas())
+		return fmt.Errorf("transaction gas exceeded max allowed (%d): %d", params.MaxTxGas, tx.Gas())
 	}
 	// Transactions can't be negative. This may never happen using RLP decoded
 	// transactions but may occur for transactions created using the RPC.

miner/worker.go

@@ -427,7 +427,7 @@ func (miner *Miner) commitTransactions(env *environment, plainTxs, blobTxs *tran
 	return nil
 }
 
-// fiterTxsAboveGas removes any transactions from a sender which exceed masGas.
+// fiterTxsAboveGas removes any transactions from the set which exceed a gas threshold.
 // If a transaction is removed, all higher-nonce transactions from the same account
 // will also be filtered out.
 func filterTxsAboveGas(txs map[common.Address][]*txpool.LazyTransaction, maxGas uint64) {