Skip to content

Lerna bootstrap improvements #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
evertonfraga opened this issue Mar 31, 2020 · 3 comments
Closed

Lerna bootstrap improvements #680

evertonfraga opened this issue Mar 31, 2020 · 3 comments

Comments

@evertonfraga
Copy link
Contributor

With the monorepo transition, we're now able to perform a lerna bootstrap --ignore-scripts to link all its packages together, as long as they are in a conformant version range.

Some dependencies were not symlinked as expected, though, resulting in using to the npm packages (remote). Listed below:

  • vm -> block ^2.2.2
  • blockchain -> block ~2.2.2
    • block -> tx ^2.1.1

Additionally, I am working on improving how ts-node runs our packages' code, without having to use npm run build for each of our dependencies, for each change.

@evertonfraga
Copy link
Contributor Author

evertonfraga commented Mar 31, 2020

$ lerna bootstrap --ignore-scripts
$ cd packages
$ ls -l */node_modules  | grep -E (node_modules|ethereumjs-blockchain|ethereumjs-block|ethereumjs-account|ethereumjs-common|ethereumjs-vm|ethereumjs-tx)

account/node_modules:

block/node_modules:
ethereumjs-blockchain -> ../../blockchain/src
ethereumjs-common -> ../../common/src
ethereumjs-tx -> ../../tx/src

blockchain/node_modules:
ethereumjs-block <============= HERE
ethereumjs-common -> ../../common/src
ethereumjs-tx <============= HERE

common/node_modules:

tx/node_modules:
ethereumjs-common -> ../../common/src

vm/node_modules:
ethereumjs-account -> ../../account/src
ethereumjs-block <============= HERE
ethereumjs-blockchain -> ../../blockchain/src
ethereumjs-common -> ../../common/src
ethereumjs-tx -> ../../tx/src

@holgerd77
Copy link
Member

With the block library this is likely due to having done these 2.2.x releases on separate branches not merged back into master due to the 3.0.0 release still outstanding. This is something we should integrate into the next major version of the VM here, this is actually long-time outstanding.

@evertonfraga
Copy link
Contributor Author

evertonfraga commented Mar 31, 2020

Right, so I need to merge these outstanding branches to the monorepo first!

thanks for highlighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants