Merge pull request rails#48650 from gmcgibbon/cpk_hmt_singular

Make has_many through singular associations build CPK records

Author: eileencodes

activerecord/lib/active_record/associations/through_association.rb

@@ -118,7 +118,9 @@ def build_record(attributes)
           target = through_association.target
 
           if inverse && target && !target.is_a?(Array)
-            attributes[inverse.foreign_key] = target.id
+            Array(target.id).zip(Array(inverse.foreign_key)).map do |primary_key_value, foreign_key_column|
+              attributes[foreign_key_column] = primary_key_value
+            end
           end
 
           super

activerecord/test/cases/associations/has_many_through_associations_test.rb

@@ -1650,6 +1650,14 @@ def test_cpk_stale_target
     assert_predicate(book.association(:order_agreements), :stale_target?)
   end
 
+  def test_cpk_association_build_through_singular
+    order = Cpk::OrderWithSingularBookChapters.create!(id: [1, 2])
+    book = order.create_book!(id: [3, 4])
+    chapter = order.chapters.build
+
+    assert_equal(chapter.book, book)
+  end
+
   private
     def make_model(name)
       Class.new(ActiveRecord::Base) { define_singleton_method(:name) { name } }

activerecord/test/models/cpk/book.rb

@@ -7,7 +7,7 @@ class Book < ActiveRecord::Base
     belongs_to :order, autosave: true, query_constraints: [:shop_id, :order_id]
     belongs_to :author, class_name: "Cpk::Author"
 
-    has_many :chapters, query_constraints: [:author_id, :book_number]
+    has_many :chapters, query_constraints: [:author_id, :book_id]
   end
 
   class BestSeller < Book
@@ -18,7 +18,7 @@ class BrokenBook < Book
   end
 
   class NullifiedBook < Book
-    has_one :chapter, query_constraints: [:author_id, :book_number], dependent: :nullify
+    has_one :chapter, query_constraints: [:author_id, :book_id], dependent: :nullify
   end
 
   class BookWithOrderAgreements < Book

activerecord/test/models/cpk/chapter.rb

@@ -7,6 +7,6 @@ class Chapter < ActiveRecord::Base
     # to be shared between different databases
     self.primary_key = [:author_id, :id]
 
-    belongs_to :book, query_constraints: [:author_id, :book_number]
+    belongs_to :book, query_constraints: [:author_id, :book_id]
   end
 end

activerecord/test/models/cpk/order.rb

@@ -24,4 +24,8 @@ class OrderWithPrimaryKeyAssociatedBook < Order
   class OrderWithNullifiedBook < Order
     has_one :book, query_constraints: [:shop_id, :order_id], dependent: :nullify
   end
+
+  class OrderWithSingularBookChapters < Order
+    has_many :chapters, through: :book
+  end
 end