Skip to content

[Question] Reduce repeated licence text #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erosman opened this issue Apr 10, 2025 · 3 comments
Closed

[Question] Reduce repeated licence text #4139

erosman opened this issue Apr 10, 2025 · 3 comments

Comments

@erosman
Copy link

erosman commented Apr 10, 2025

Bundling of monaco-editor produces 1,384 lines (78 kb) of repeated licence text.

Are they all legally necessary?
Can it be reduced to one for all?

/*! Bundled license information:

monaco-editor/esm/vs/base/browser/dompurify/dompurify.js:
  (*! @license DOMPurify 3.1.7 | (c) Cure53 and other contributors | Released under the Apache license 2.0 and Mozilla Public License 2.0 | github.com/cure53/DOMPurify/blob/3.1.7/LICENSE *)

monaco-editor/esm/vs/basic-languages/abap/abap.js:
  (*!-----------------------------------------------------------------------------
   * Copyright (c) Microsoft Corporation. All rights reserved.
   * Version: 0.52.2(404545bded1df6ffa41ea0af4e8ddb219018c6c1)
   * Released under the MIT license
   * https://github.com/microsoft/monaco-editor/blob/main/LICENSE.txt
   *-----------------------------------------------------------------------------*)

monaco-editor/esm/vs/basic-languages/apex/apex.js:
  (*!-----------------------------------------------------------------------------
   * Copyright (c) Microsoft Corporation. All rights reserved.
   * Version: 0.52.2(404545bded1df6ffa41ea0af4e8ddb219018c6c1)
   * Released under the MIT license
   * https://github.com/microsoft/monaco-editor/blob/main/LICENSE.txt
   *-----------------------------------------------------------------------------*)

monaco-editor/esm/vs/basic-languages/azcli/azcli.js:
  (*!-----------------------------------------------------------------------------
   * Copyright (c) Microsoft Corporation. All rights reserved.
   * Version: 0.52.2(404545bded1df6ffa41ea0af4e8ddb219018c6c1)
   * Released under the MIT license
   * https://github.com/microsoft/monaco-editor/blob/main/LICENSE.txt
   *-----------------------------------------------------------------------------*)

monaco-editor/esm/vs/basic-languages/bat/bat.js:
  (*!-----------------------------------------------------------------------------
   * Copyright (c) Microsoft Corporation. All rights reserved.
   * Version: 0.52.2(404545bded1df6ffa41ea0af4e8ddb219018c6c1)
   * Released under the MIT license
   * https://github.com/microsoft/monaco-editor/blob/main/LICENSE.txt
   *-----------------------------------------------------------------------------*)
...
@evanw
Copy link
Owner

evanw commented Apr 10, 2025

I don't know how necessary or not these notices are. I'm not able to provide you with legal advice.

You can move them to another file with linked/external if you don't want them to impact download time: https://esbuild.github.io/api/#legal-comments. Or you can turn them off entirely with none.

@erosman
Copy link
Author

erosman commented Apr 10, 2025

Fair enough. Thank you for the help.

If it was possible to condense the repeated legal-comment, this topic can be changed to a feature request.
Otherwise, feel free to close this topic.

For example:

/*! Bundled license information:

monaco-editor/esm/vs/base/browser/dompurify/dompurify.js:
  (*! @license DOMPurify 3.1.7 | (c) Cure53 and other contributors | Released under the Apache license 2.0 and Mozilla Public License 2.0 | github.com/cure53/DOMPurify/blob/3.1.7/LICENSE *)

monaco-editor/esm/vs/basic-languages/abap/abap.js:
monaco-editor/esm/vs/basic-languages/apex/apex.js:
monaco-editor/esm/vs/basic-languages/azcli/azcli.js:
monaco-editor/esm/vs/basic-languages/bat/bat.js:
...
  (*!-----------------------------------------------------------------------------
   * Copyright (c) Microsoft Corporation. All rights reserved.
   * Version: 0.52.2(404545bded1df6ffa41ea0af4e8ddb219018c6c1)
   * Released under the MIT license
   * https://github.com/microsoft/monaco-editor/blob/main/LICENSE.txt
   *-----------------------------------------------------------------------------*)

@evanw
Copy link
Owner

evanw commented Apr 23, 2025

That sounds like a reasonable feature request to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@evanw @erosman and others