Skip to content

Forecast: solar adjust details #19724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2025
Merged

Forecast: solar adjust details #19724

merged 3 commits into from
Mar 14, 2025

Conversation

naltatis
Copy link
Member

@naltatis naltatis commented Mar 12, 2025

fixes #19717
fixes #19649

💯 show real/forecast difference in percent
🐜 difference between +/- 5% are rated "pretty accurate" (no percentage, still adjustment)
🧪 also adjust forecast in energy flow diagram (main ui)

forecast too low
too low

forecast too high
too high

not enough data
not enough data

@naltatis naltatis added enhancement New feature or request ux User experience/ interface labels Mar 12, 2025
@naltatis naltatis requested a review from andig March 12, 2025 15:37
@andig
Copy link
Member

andig commented Mar 12, 2025

Could we simplify and shorten the wording? It would be great to simply show (+/- X%) rather than "forecast is....". Imho makes it easier to read, too.

It would still be nice to see the actual forecasted value for current time, or maybe a Y axis. We show energy, so why not power?

@naltatis
Copy link
Member Author

naltatis commented Mar 12, 2025

Could we simplify and shorten the wording? It would be great to simply show (+/- X%) rather than "forecast is....". Imho makes it easier to read, too.

I opted to go the explicit way because with +/- x% it is not always clear what this means. I'm open to better and more concise wording suggestions, but just showing the number is not enough.

@andig
Copy link
Member

andig commented Mar 12, 2025

Together with the option titled "adjust" imho +/- percent value is clear as to what it does.

@naltatis
Copy link
Member Author

@andig please make suggestions with the complete wording and the individual scenarios (including no diff)

@andig
Copy link
Member

andig commented Mar 12, 2025

  • Adjust solar forecast based on real production data (+12%).
  • Adjust solar forecast based on real production data (-5%).
  • Adjust solar forecast based on real production data.

@naltatis
Copy link
Member Author

What about the "Not enough data case"? Omit?

@RenatusRo
Copy link
Contributor

  • Adjust solar forecast based on real production data (+12%).

Adjust solar forecast by +12% based on real production data.

@andig
Copy link
Member

andig commented Mar 13, 2025

I would appreciate the number clearly and easily recognizable, that is at the end of the line. The „not enough data“ case can just omit it, same as today.

@naltatis
Copy link
Member Author

Adjust solar forecast based on real production data (+12%).
Adjust solar forecast based on real production data (-5%).
Adjust solar forecast based on real production data.

Switched to this notation.

Bildschirmfoto 2025-03-13 um 16 38 00

@Maschga
Copy link
Contributor

Maschga commented Mar 13, 2025

Lässt sich das auch auf gerade Zahlen runden, also statt 1.291% auf 1%?
Die Nachkommastellen sind meiner Meinung nach nicht mehr ausschlaggebend.

@naltatis
Copy link
Member Author

@Maschga Der letzte Screenshot ist ein super schlechtes Datenbeispiel. Hier wird in der Tat um +1291% angepasst. Das ist kein Komma sondern der deutsche Tausendertrenner :D
Die Prozentwerte werden auf gerade % gerundet.

@andig andig merged commit 5ef4b50 into master Mar 14, 2025
7 checks passed
@andig andig deleted the feature/solar-adjust-details branch March 14, 2025 08:52
@RTTTC
Copy link
Contributor

RTTTC commented Mar 20, 2025

@naltatis - some feedback on this feature - for some reason (adjustment too aggressive?) sometimes I see correction that is way too large, such as -103%, even -185%
It should never reach a -100% compensation, in my opinion, unless PV size is misconfigured. (Mine is OK)

@andig
Copy link
Member

andig commented Mar 20, 2025

Can you share a debug log for this?

@RTTTC
Copy link
Contributor

RTTTC commented Mar 20, 2025

Unable to provide logs at this time since I have restarted evcc and UI logs are gone.
Please ignore this issue for now, I will investigate further in the next few days and will update here.

I have a suspicion at this time that problem is due to my system wiring - (there is a constant load of 1kW temporarily (for two weeks) connected in such a way, that for example during the night I get a orange warning that my PV generation sign is negative)

@RTTTC
Copy link
Contributor

RTTTC commented Mar 20, 2025

Yes, as always - everything is clear in the log !

Last few days were cloudy, not much sun, and my temporary 1kW "vampire drain" was the culprit, generating significant "negative solar generation" during the nights..

Mar 19 04:59:14 picharger evcc[8357]: [site  ] DEBUG 2025/03/19 04:59:14 pv 1 power: -1016W
Mar 19 04:59:14 picharger evcc[8357]: [site  ] WARN 2025/03/19 04:59:14 pv 1 power: -1016W is negative - check configuration if sign is correct
Mar 19 04:59:16 picharger evcc[8357]: [site  ] DEBUG 2025/03/19 04:59:16 solar forecast: accumulated 0.000kWh, produced -9.229kWh, scale -68401.375
Mar 20 05:42:33 picharger evcc[8357]: [site  ] DEBUG 2025/03/20 05:42:33 pv 1 power: -1005W
Mar 20 05:42:33 picharger evcc[8357]: [site  ] WARN 2025/03/20 05:42:33 pv 1 power: -1005W is negative - check configuration if sign is correct
Mar 20 05:42:35 picharger evcc[8357]: [site  ] DEBUG 2025/03/20 05:42:35 solar forecast: accumulated 31.198kWh, produced -9.015kWh, scale -0.289

I am sure everything will be correct when this vampire drain will be disconnected.

@andig
Copy link
Member

andig commented Mar 20, 2025

Your config is broken as the warning indicates. Please resolve warnings before opening issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux User experience/ interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solar prognosis: show deviation and power Prognose Solarertrag stimmt nicht nicht überein
5 participants