Skip to content

[REF] Translate submatrix linear operator to purely PyTorch #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
f-dangel opened this issue Feb 5, 2025 · 1 comment · May be fixed by #177
Open

[REF] Translate submatrix linear operator to purely PyTorch #171

f-dangel opened this issue Feb 5, 2025 · 1 comment · May be fixed by #177
Labels
enhancement New feature or request
Milestone
Linear operators ...

Comments

@f-dangel
Copy link
Owner

f-dangel commented Feb 5, 2025

At the moment, the submatrix operator is purely SciPy.
We should refactor it into purely PyTorch to make it compatible with PyTorch linops without having to convert to SciPy.
@f-dangel f-dangel added the enhancement New feature or request label Feb 5, 2025
@f-dangel f-dangel linked a pull request Feb 25, 2025 that will close this issue
Open
@andres-fr
Copy link
Collaborator

Is this part of 2.0.1 already?
If not, how could I help getting it on a release?

I am planning a skerch release and not having to swap from torch to numpy and back every time a linop is accessed would save some overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Linear operators for PyTorch and SciPy
Development

Successfully merging a pull request may close this issue.

[REF] Implement SubmatrixLinearOperator purely in PyTorch f-dangel/curvlinops
2 participants
@andres-fr @f-dangel