Skip to content

OpenAPI: Remove diff-compatibility emptySpace hack #6837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manusa opened this issue Jan 29, 2025 · 0 comments · Fixed by #6838
Closed

OpenAPI: Remove diff-compatibility emptySpace hack #6837

manusa opened this issue Jan 29, 2025 · 0 comments · Fixed by #6838
Assignees
Labels
component/kubernetes-model Deals with the kubernetes-model
Milestone

Comments

@manusa
Copy link
Member

manusa commented Jan 29, 2025

Description

The new model generation approach implemented in #6130, added a hack to add an empty space in some parts of the generated code.

The main purpose was to minimize the number of diffs in the generated code with the previous (Go) approach.
This hack is no longer necessary and should be removed.

ret.put("emptySpace", " "); // TODO: remove after generator migration, current workaround so that models match with jsonschema2pojo

@manusa manusa added this to the 7.1.0 milestone Jan 29, 2025
@manusa manusa moved this to Planned in Eclipse JKube Jan 29, 2025
@manusa manusa added the component/kubernetes-model Deals with the kubernetes-model label Jan 29, 2025
@manusa manusa self-assigned this Jan 29, 2025
@manusa manusa moved this from Planned to In Progress in Eclipse JKube Jan 29, 2025
@manusa manusa moved this from In Progress to Review in Eclipse JKube Jan 29, 2025
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/kubernetes-model Deals with the kubernetes-model
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant