Skip to content

Commit 5685e8a

Browse files
authored
fix(v2): fix cannot import css from node_modules in userland (#1463)
1 parent e873c14 commit 5685e8a

File tree

5 files changed

+2
-86
lines changed

5 files changed

+2
-86
lines changed

packages/docusaurus/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,7 @@
7272
"webpack-bundle-analyzer": "^3.1.0",
7373
"webpack-dev-server": "^3.2.1",
7474
"webpack-merge": "^4.1.4",
75-
"webpack-nicelog": "^2.3.1",
76-
"webpack-node-externals": "^1.7.2"
75+
"webpack-nicelog": "^2.3.1"
7776
},
7877
"peerDependencies": {
7978
"react": "^16.8.4",

packages/docusaurus/src/client/PendingNavigation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import React from 'react';
99
import {Route, withRouter} from 'react-router-dom';
1010
import nprogress from 'nprogress';
1111
import preload from './preload';
12-
import './nprogress.css';
12+
import 'nprogress/nprogress.css';
1313

1414
nprogress.configure({showSpinner: false});
1515

packages/docusaurus/src/client/nprogress.css

Lines changed: 0 additions & 75 deletions
This file was deleted.

packages/docusaurus/src/webpack/server.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
* LICENSE file in the root directory of this source tree.
66
*/
77

8-
const nodeExternals = require('webpack-node-externals');
98
const path = require('path');
109
const StaticSiteGeneratorPlugin = require('static-site-generator-webpack-plugin');
1110
const WebpackNiceLog = require('webpack-nicelog');
@@ -37,8 +36,6 @@ module.exports = function createServerConfig(props) {
3736
globalObject: 'this',
3837
},
3938
target: 'node',
40-
// No need to bundle its node_modules dependencies since we're bundling for static html generation (backend)
41-
externals: [nodeExternals()],
4239
plugins: [
4340
// Wait until manifest from client bundle is generated
4441
new WaitPlugin({

yarn.lock

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13946,11 +13946,6 @@ webpack-nicelog@^2.3.1:
1394613946
react-dev-utils "^5.0.1"
1394713947
webpackbar "^2.6.1"
1394813948

13949-
webpack-node-externals@^1.7.2:
13950-
version "1.7.2"
13951-
resolved "https://registry.yarnpkg.com/webpack-node-externals/-/webpack-node-externals-1.7.2.tgz#6e1ee79ac67c070402ba700ef033a9b8d52ac4e3"
13952-
integrity sha512-ajerHZ+BJKeCLviLUUmnyd5B4RavLF76uv3cs6KNuO8W+HuQaEs0y0L7o40NQxdPy5w0pcv8Ew7yPUAQG0UdCg==
13953-
1395413949
webpack-sources@^0.2.0:
1395513950
version "0.2.3"
1395613951
resolved "https://registry.yarnpkg.com/webpack-sources/-/webpack-sources-0.2.3.tgz#17c62bfaf13c707f9d02c479e0dcdde8380697fb"

0 commit comments

Comments
 (0)