Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Commit 4a9a6a8

Browse files
noelyoofacebook-github-bot
noelyoo
authored andcommitted
Add Node.js version 10 for CI (#1909)
Summary: **Summary** This PR adds nodejs version `10` for the Travis Ci build Details: * https://github.com/nodejs/Release#end-of-life-releases * https://docs.travis-ci.com/user/languages/javascript-with-nodejs/#specifying-nodejs-versions ![image](https://user-images.githubusercontent.com/25740248/47252831-f1f67580-d485-11e8-8ae0-1525cfd154df.png) **Test Plan** Travis CI test Pull Request resolved: #1909 Differential Revision: D10487838 fbshipit-source-id: 98d98ea38da66752c6c73fd379acb024058f09a3
1 parent 11d7379 commit 4a9a6a8

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ language: node_js
22

33
node_js:
44
- 8
5+
- 10
56

67
sudo: false
78

package.json

+4-1
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,11 @@
8484
"vinyl-buffer": "^1.0.0",
8585
"webpack-stream": "^4.0.0"
8686
},
87+
"resolutions": {
88+
"gulp/**/natives": "1.1.3"
89+
},
8790
"devEngines": {
88-
"node": "8.x || 9.x",
91+
"node": "8.x || 9.x || 10.x",
8992
"npm": "2.x || 3.x || 5.x || 6.x"
9093
},
9194
"jest": {

yarn.lock

+3-3
Original file line numberDiff line numberDiff line change
@@ -4207,9 +4207,9 @@ nan@^2.3.0:
42074207
version "2.8.0"
42084208
resolved "https://registry.yarnpkg.com/nan/-/nan-2.8.0.tgz#ed715f3fe9de02b57a5e6252d90a96675e1f085a"
42094209

4210-
natives@^1.1.0:
4211-
version "1.1.1"
4212-
resolved "https://registry.yarnpkg.com/natives/-/natives-1.1.1.tgz#011acce1f7cbd87f7ba6b3093d6cd9392be1c574"
4210+
natives@1.1.3, natives@^1.1.0:
4211+
version "1.1.3"
4212+
resolved "http://registry.npmjs.org/natives/-/natives-1.1.3.tgz#44a579be64507ea2d6ed1ca04a9415915cf75558"
42134213

42144214
natural-compare@^1.4.0:
42154215
version "1.4.0"

0 commit comments

Comments
 (0)