Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Commit 7017825

Browse files
flarniefacebook-github-bot
flarnie
authored and
facebook-github-bot
committed
Update weekly meeting notes from Oct. 2017 - Jan. 2018
Summary: Still going~ 🚂 Closes #1634 Differential Revision: D6831211 fbshipit-source-id: 5f1a02f55c4db003ff1d4842a0040d05aedfd478
1 parent dc5ca7f commit 7017825

11 files changed

+85
-0
lines changed

‎meta/meeting-notes/2017-10-06-weekly-meeting.md

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Draft.js Weekly 10/06/17
2+
3+
* Discussed race conditions in Draft.js

‎meta/meeting-notes/2017-10-13-weekly-meeting.md

+20
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# Draft.js Weekly 10/13/17
2+
3+
* * Idea: Highlight broken/invalid text in red (Sophie's comments below:)
4+
* bad things happen when we get text in a DraftEditorLeaf span that's outside the innermost one
5+
* in particular, when text content is a sibling of the inner span here, it looks like it's real text but draft doesn't handle it properly
6+
* idea: CSS to make it bright red
7+
* so that people are more likely to notice if certain keyboard shortcuts, for example, cause the text to get out of sync with draft
8+
* they'll complain "hey, whenever I do this really weird thing, I get red text" and then we'll have a good avenue to say "…well yeah. don't do that. also maybe we'll fix it"
9+
* -> Maybe try this for one FB use case first and see how it goes? Or land under a GK and enable within FB?
10+
11+
12+
* One World for continuous testing
13+
* Notes on setting this up within FB
14+
* Might be useful as regression tests
15+
* Could still add regression tests that don't use live browser
16+
* What about for React?
17+
* Dan and Nate and Brendan are looking at this with 3rd party extensions, like Saucelabs
18+
* Problem; some of our fixtures are hard to write automated test for. Some bugs in the past related to setting the value correctly, but looking visually it wasn't showing up. Hard to catch this with automated test.
19+
* Consider adding Jest tests for PRs that pass tests but would break everything
20+
* Tests are awesome. :| Let's add more. :D

‎meta/meeting-notes/2017-10-20-weekly-meeting.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Draft.js Weekly 10/20/17
2+
3+
* Potentially onboarding external maintainers
4+
* Upcoming project to add new improved features to Draft.js, within FB
5+
* Bug Bash planning

‎meta/meeting-notes/2017-11-03-weekly-meeting.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Draft.js Weekly 11/03/17
2+
3+
* Update on new experimental feature
4+
* Migrating docs to Docusaurus - https://docusaurus.io/
5+
* Tests being rewritten with Jest snapshots

‎meta/meeting-notes/2017-11-17-weekly-meeting.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Draft.js Weekly 11/17/17
2+
3+
* Continued work moving docs to Docusaurus
4+
* Jest snapshot test conversion landed
5+
* New maintainers

‎meta/meeting-notes/2017-12-01-weekly-meeting.md

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# Draft.js Weekly 12/01/17
2+
3+
* Moving weekly meeting time so more folks can attend
4+
* Update on Docusaurus migration

‎meta/meeting-notes/2017-12-08-weekly-meeting.md

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# Draft.js Weekly 12/08/17
2+
3+
* Review ongoing work on experimental feature
4+
* Need to fix CI

‎meta/meeting-notes/2017-12-15-weekly-meeting.md

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
# Draft.js Weekly 12/15/17
2+
3+
* Discussed issues which arise when using Draft.js with React's "async
4+
scheduling" enabled.

‎meta/meeting-notes/2018-01-05-weekly-meeting.md

+10
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
# Draft.js Weekly 01/05/18
2+
3+
* Docusaurus migration almost complete, thanks @aadsm
4+
* Update on experimental features
5+
* Planning on rolling out and testing within FB first, no plans to release to
6+
open source for at least next 6 months.
7+
8+
* Demo of debugger/playground tool - thanks @mitermayer & @juliankrispel
9+
* 0.11.0 update?
10+
* Nobody is working on it, not sure when we will finish roll out

‎meta/meeting-notes/2018-01-19-weekly-meeting.md

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Draft.js Weekly 01/19/18
2+
3+
* Tried to fix CI, linting inconsistencies

‎meta/meeting-notes/2018-01-26-weekly-meeting.md

+22
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Draft.js Weekly 01/26/18
2+
3+
* Switching to biweekly for a while
4+
* Discussed support for upcoming API changes in React in Draft.js
5+
* No updates on experimental new features
6+
* Docusaurus docs migration
7+
* Planning on looking into Netlify
8+
* Might land change before deciding about Netlify
9+
* Why don't we support mobile web, and how to tell the community this
10+
* Really it's just Android we don't support
11+
* android behaves very differently from most desktop browsers
12+
* iOS behaves mostly like a desktop browser
13+
* write one really good response and link to that
14+
* Discussed internal PR to expose start/end of positions of decorated
15+
component within a contentBlock (D6712533)
16+
* lgtm!
17+
* Discussed more potential new maintainers
18+
* How to fix/import PRs which don't give maintainers permission to
19+
push to them?
20+
* There is still a bug with selecting and typing the same character;
21+
* Flarnie will look at this again
22+

0 commit comments

Comments
 (0)