Skip to content
This repository was archived by the owner on Feb 6, 2023. It is now read-only.

Commit ce7f677

Browse files
aferciafacebook-github-bot
authored andcommitted
Bring back the ariaOwneeID prop. (#1883)
Summary: **Summary** Reverts 7f0cab2 to bring back the `ariaOwneeID` prop. The ARIA property `aria-owns` is required for the combobox ARIA widget, in both ARIA 1.0 and 1.1. Some plugins, for example the Mentions and Emoji plugins, still pass an `ariaOwneeID` prop which at the moment doesn't do anything. Also, without `aria-owns`, some browser / screen reader combinations don't read out the suggestions at all. For more details please refer to the related issue #1736. Fixes #1736. Pull Request resolved: #1883 Reviewed By: vdurmont Differential Revision: D10371390 Pulled By: vdurmont fbshipit-source-id: 140282124128437e0d8cc9b08490420c3dc81dc1
1 parent 4a9a6a8 commit ce7f677

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

src/component/base/DraftEditor.react.js

+1
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,7 @@ class DraftEditor extends React.Component<DraftEditorProps, State> {
377377
aria-label={this.props.ariaLabel}
378378
aria-labelledby={this.props.ariaLabelledBy}
379379
aria-multiline={this.props.ariaMultiline}
380+
aria-owns={readOnly ? null : this.props.ariaOwneeID}
380381
autoCapitalize={this.props.autoCapitalize}
381382
autoComplete={this.props.autoComplete}
382383
autoCorrect={this.props.autoCorrect}

src/component/base/DraftEditorProps.js

+1
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ export type DraftEditorProps = {
100100
ariaLabel?: string,
101101
ariaLabelledBy?: string,
102102
ariaMultiline?: boolean,
103+
ariaOwneeID?: string,
103104

104105
webDriverTestID?: string,
105106

0 commit comments

Comments
 (0)