This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Fixes warning for missing keys in example color controls #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiopro
changed the title
There was a problem hiding this comment.
claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
…hive#1853) Summary: **Summary** Fixes a warning in the color examples for missing keys for elements in an array for the style controls. ``` react.development.js:336 Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of `ColorControls`. See https://fb.me/react-warning-keys for more information. in StyleButton (created by ColorControls) in ColorControls (created by ColorfulEditorExample) in div (created by ColorfulEditorExample) in ColorfulEditorExample ``` **Test Plan** Manual tests on Chrome, warnings are gone **Note:** This PR also fixes the [Travis CI build failure](https://travis-ci.org/facebook/draft-js/jobs/424170309) introduced with e6c693c Pull Request resolved: facebookarchive#1853 Differential Revision: D9654616 fbshipit-source-id: 1e4e9a4ef2eb896306404acc31623076e107b91c
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Fixes a warning in the color examples for missing keys for elements in an array for the style controls. ``` react.development.js:336 Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of `ColorControls`. See https://fb.me/react-warning-keys for more information. in StyleButton (created by ColorControls) in ColorControls (created by ColorfulEditorExample) in div (created by ColorfulEditorExample) in ColorfulEditorExample ``` **Test Plan** Manual tests on Chrome, warnings are gone **Note:** This PR also fixes the [Travis CI build failure](https://travis-ci.org/facebook/draft-js/jobs/424170309) introduced with e6c693c Pull Request resolved: facebookarchive/draft-js#1853 Differential Revision: D9654616 fbshipit-source-id: 1e4e9a4ef2eb896306404acc31623076e107b91c
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** Fixes a warning in the color examples for missing keys for elements in an array for the style controls. ``` react.development.js:336 Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of `ColorControls`. See https://fb.me/react-warning-keys for more information. in StyleButton (created by ColorControls) in ColorControls (created by ColorfulEditorExample) in div (created by ColorfulEditorExample) in ColorfulEditorExample ``` **Test Plan** Manual tests on Chrome, warnings are gone **Note:** This PR also fixes the [Travis CI build failure](https://travis-ci.org/facebook/draft-js/jobs/424170309) introduced with d267826 Pull Request resolved: facebookarchive/draft-js#1853 Differential Revision: D9654616 fbshipit-source-id: 1e4e9a4ef2eb896306404acc31623076e107b91c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a warning in the color examples for missing keys for elements in an array for the style controls.
Test Plan
Manual tests on Chrome, warnings are gone
Note: This PR also fixes the Travis CI build failure introduced with e6c693c