This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Fix tex and universal examples crash because of different React versions (#1756) #1931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudcolas
changed the title
thibaudcolas
changed the title
This was referenced Nov 8, 2018
niveditc
approved these changes
Nov 11, 2018
There was a problem hiding this comment.
@niveditc is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
jdecked
pushed a commit
to twitter-forks/draft-js
that referenced
this pull request
Oct 9, 2019
…ons (facebookarchive#1756) (facebookarchive#1931) Summary: **Summary** Fixes facebookarchive#1756, and facebookarchive#1930. The tex and universal examples have their own dependencies, and relied on a different version of `react`/`react-dom` from the one defined for Draft.js. This caused a JS error when running the examples. I have also added the missing lockfile for the universal example. **Test Plan** - Make a clean copy of the project - For both examples, go through the instructions to install their dependencies and build them. - Open the examples in a browser, and attempt to type in the editor(s) Pull Request resolved: facebookarchive#1931 Differential Revision: D13019619 fbshipit-source-id: 3451737816a5ba9fe283cb65b285fd5fb5e5532a
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
…ons (#1756) (#1931) Summary: **Summary** Fixes #1756, and #1930. The tex and universal examples have their own dependencies, and relied on a different version of `react`/`react-dom` from the one defined for Draft.js. This caused a JS error when running the examples. I have also added the missing lockfile for the universal example. **Test Plan** - Make a clean copy of the project - For both examples, go through the instructions to install their dependencies and build them. - Open the examples in a browser, and attempt to type in the editor(s) Pull Request resolved: facebookarchive/draft-js#1931 Differential Revision: D13019619 fbshipit-source-id: 3451737816a5ba9fe283cb65b285fd5fb5e5532a
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
…ons (#1756) (#1931) Summary: **Summary** Fixes #1756, and #1930. The tex and universal examples have their own dependencies, and relied on a different version of `react`/`react-dom` from the one defined for Draft.js. This caused a JS error when running the examples. I have also added the missing lockfile for the universal example. **Test Plan** - Make a clean copy of the project - For both examples, go through the instructions to install their dependencies and build them. - Open the examples in a browser, and attempt to type in the editor(s) Pull Request resolved: facebookarchive/draft-js#1931 Differential Revision: D13019619 fbshipit-source-id: 3451737816a5ba9fe283cb65b285fd5fb5e5532a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1756, and #1930. The tex and universal examples have their own dependencies, and relied on a different version of
react/react-domfrom the one defined for Draft.js. This caused a JS error when running the examples.I have also added the missing lockfile for the universal example.
Test Plan