Correct warning condition #2049
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Hey @unshift, welcome to Draft.js and thanks for spending the time to submit a PR! You're absolutely right, the Therefore, in order to warn when the selection is not collapsed, the first argument must be |
|
I reproduced the problem in the examples. This is good to merge. |
There was a problem hiding this comment.
@claudiopro is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request has been merged in ffd8f59. |
|
Good to know those were incorrect! Thank you! |
Summary: **Summary** To my knowledge, ```warning``` works the way ```invariant``` does; it warns if the first argument is false not true. Prior to this PR, ```moveSelectionBackward``` warns when the selection is collapsed when it should do the opposite. Pull Request resolved: facebookarchive#2049 Differential Revision: D14699712 fbshipit-source-id: bd649fa6fdc60346d80be27ab4217324c3ef21d6
Summary: **Summary** To my knowledge, ```warning``` works the way ```invariant``` does; it warns if the first argument is false not true. Prior to this PR, ```moveSelectionBackward``` warns when the selection is collapsed when it should do the opposite. Pull Request resolved: facebookarchive#2049 Differential Revision: D14699712 fbshipit-source-id: bd649fa6fdc60346d80be27ab4217324c3ef21d6
Summary: **Summary** To my knowledge, ```warning``` works the way ```invariant``` does; it warns if the first argument is false not true. Prior to this PR, ```moveSelectionBackward``` warns when the selection is collapsed when it should do the opposite. Pull Request resolved: facebookarchive/draft-js#2049 Differential Revision: D14699712 fbshipit-source-id: bd649fa6fdc60346d80be27ab4217324c3ef21d6
Summary
To my knowledge,
warningworks the wayinvariantdoes; it warns if the first argument is false not true.Prior to this PR,
moveSelectionBackwardwarns when the selection is collapsed when it should do the opposite.