Skip to content

Commit eabf5fc

Browse files
neildharfacebook-github-bot
authored andcommitted
Always enable debugger by default
Summary: We currently enable the debugger by default on all platforms except Android. On Android, we then manually enable the debugger in debug builds. Instead, change it so the debugger is manually disabled in release builds, to simplify the setup. Changelog: [Internal] Reviewed By: jpporto Differential Revision: D35347444 fbshipit-source-id: a97bba0c65c61c211cf9e361e7091343a2c6416f
1 parent 26468cc commit eabf5fc

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

CMakeLists.txt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -211,11 +211,7 @@ set(HERMES_USE_STATIC_ICU OFF CACHE BOOL
211211
set(HERMES_UNICODE_LITE OFF CACHE BOOL
212212
"Enable to use internal no-op unicode functionality instead of relying on underlying system libraries")
213213

214-
set(HERMES_ENABLE_DEBUGGER_DEFAULT OFF)
215-
if (NOT HERMES_IS_MOBILE_BUILD)
216-
set(HERMES_ENABLE_DEBUGGER_DEFAULT ON)
217-
endif()
218-
set(HERMES_ENABLE_DEBUGGER ${HERMES_ENABLE_DEBUGGER_DEFAULT} CACHE BOOL
214+
set(HERMES_ENABLE_DEBUGGER ON CACHE BOOL
219215
"Build with debugger support")
220216

221217
set(HERMES_ENABLE_IR_INSTRUMENTATION OFF CACHE BOOL

android/hermes/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ android {
4747
debug {
4848
externalNativeBuild {
4949
cmake {
50-
arguments "-DHERMES_ENABLE_DEBUGGER=True"
5150
// JS developers aren't VM developers. Give them a faster build.
5251
arguments "-DCMAKE_BUILD_TYPE=Release"
5352
}
@@ -56,6 +55,7 @@ android {
5655
release {
5756
externalNativeBuild {
5857
cmake {
58+
arguments "-DHERMES_ENABLE_DEBUGGER=False"
5959
arguments "-DCMAKE_BUILD_TYPE=MinSizeRel"
6060
}
6161
}

0 commit comments

Comments
 (0)