Skip to content

Commit 462c7ed

Browse files
committed
2015-02-07 updates
- Fixes reference to ReactPackager middleware | Tyler Smalley - [ReactKit] Fix bug where <Text /> did not refresh (in RCTText) | Alex Akers - Removed duplication in react-native.js | Nick Lockwood - [ReactNative] Patch up ReactPerf to work again | Ben Alpert
1 parent 9674c99 commit 462c7ed

File tree

5 files changed

+36
-48
lines changed

5 files changed

+36
-48
lines changed

Libraries/ReactIOS/ReactIOSMount.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
var RKUIManager = require('NativeModulesDeprecated').RKUIManager;
99

1010
var ReactIOSTagHandles = require('ReactIOSTagHandles');
11+
var ReactPerf = require('ReactPerf');
1112

1213
var instantiateReactComponent = require('instantiateReactComponent');
1314
var invariant = require('invariant');
@@ -47,7 +48,7 @@ var ReactIOSMount = {
4748
TOP_ROOT_NODE_IDS[topRootNodeID] = true;
4849

4950
var childRootNodeID = instanceNumberToChildRootID(
50-
topRootNodeID,
51+
topRootNodeID,
5152
ReactIOSMount.instanceCount++
5253
);
5354
ReactIOSMount._instancesByContainerID[topRootNodeID] = instance;
@@ -113,4 +114,10 @@ var ReactIOSMount = {
113114
}
114115
};
115116

117+
ReactIOSMount.renderComponent = ReactPerf.measure(
118+
'ReactMount',
119+
'_renderNewRootComponent',
120+
ReactIOSMount.renderComponent
121+
);
122+
116123
module.exports = ReactIOSMount;

Libraries/react-native/react-native.js

Lines changed: 20 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -5,49 +5,27 @@
55
*/
66
'use strict';
77

8-
var Bundler = require('Bundler');
9-
var ExpandingText = require('ExpandingText');
10-
var Image = require('Image');
11-
var ListView = require('ListView');
12-
var ListViewDataSource = require('ListViewDataSource');
13-
var NavigatorIOS = require('NavigatorIOS');
14-
var StatusBarIOS = require('StatusBarIOS');
15-
var PixelRatio = require('PixelRatio');
16-
var React = require('React');
17-
var ScrollView = require('ScrollView');
18-
var SpinnerIOS = require('SpinnerIOS');
19-
var StyleSheet = require('StyleSheet');
20-
var Text = require('Text');
21-
var TextInput = require('TextInput');
22-
var TimerMixin = require('TimerMixin');
23-
var TouchableHighlight = require('TouchableHighlight');
24-
var TouchableWithoutFeedback = require('TouchableWithoutFeedback');
25-
var View = require('View');
26-
27-
var invariant = require('invariant');
28-
var ix = require('ix');
29-
308
var ReactNative = {
31-
...React,
32-
Bundler,
33-
ExpandingText,
34-
Image,
35-
ListView,
36-
ListViewDataSource,
37-
NavigatorIOS,
38-
StatusBarIOS,
39-
PixelRatio,
40-
ScrollView,
41-
SpinnerIOS,
42-
StyleSheet,
43-
Text,
44-
TextInput,
45-
TimerMixin,
46-
TouchableHighlight,
47-
TouchableWithoutFeedback,
48-
View,
49-
invariant,
50-
ix,
9+
...require('React'),
10+
Bundler: require('Bundler'),
11+
ExpandingText: require('ExpandingText'),
12+
Image: require('Image'),
13+
ListView: require('ListView'),
14+
ListViewDataSource: require('ListViewDataSource'),
15+
NavigatorIOS: require('NavigatorIOS'),
16+
PixelRatio: require('PixelRatio'),
17+
ScrollView: require('ScrollView'),
18+
SpinnerIOS: require('SpinnerIOS'),
19+
StatusBarIOS: require('StatusBarIOS'),
20+
StyleSheet: require('StyleSheet'),
21+
Text: require('Text'),
22+
TextInput: require('TextInput'),
23+
TimerMixin: require('TimerMixin'),
24+
TouchableHighlight: require('TouchableHighlight'),
25+
TouchableWithoutFeedback: require('TouchableWithoutFeedback'),
26+
View: require('View'),
27+
invariant: require('invariant'),
28+
ix: require('ix'),
5129
};
5230

5331
module.exports = ReactNative;

ReactKit/Views/RCTText.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
@property (nonatomic, copy) NSAttributedString *attributedText;
88
@property (nonatomic, assign) NSLineBreakMode lineBreakMode;
9-
@property (nonatomic, assign) NSInteger numberOfLines;
9+
@property (nonatomic, assign) NSUInteger numberOfLines;
1010

1111
- (NSNumber *)reactTagAtPoint:(CGPoint)point;
1212

ReactKit/Views/RCTText.m

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,18 @@ - (NSAttributedString *)attributedText
4040
- (void)setAttributedText:(NSAttributedString *)attributedText
4141
{
4242
[_textStorage setAttributedString:attributedText];
43+
[self setNeedsDisplay];
4344
}
4445

45-
- (NSInteger)numberOfLines
46+
- (NSUInteger)numberOfLines
4647
{
4748
return _textContainer.maximumNumberOfLines;
4849
}
4950

50-
- (void)setNumberOfLines:(NSInteger)numberOfLines
51+
- (void)setNumberOfLines:(NSUInteger)numberOfLines
5152
{
52-
_textContainer.maximumNumberOfLines = MAX(0, numberOfLines);
53+
_textContainer.maximumNumberOfLines = numberOfLines;
54+
[self setNeedsDisplay];
5355
}
5456

5557
- (NSLineBreakMode)lineBreakMode
@@ -60,6 +62,7 @@ - (NSLineBreakMode)lineBreakMode
6062
- (void)setLineBreakMode:(NSLineBreakMode)lineBreakMode
6163
{
6264
_textContainer.lineBreakMode = lineBreakMode;
65+
[self setNeedsDisplay];
6366
}
6467

6568
- (void)layoutSubviews

packager/packager.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ function openStackFrameInEditor(req, res, next) {
6767
}
6868

6969
function getAppMiddleware(options) {
70-
return ReactPackager.catalystMiddleware({
70+
return ReactPackager.middleware({
7171
dev: true,
7272
projectRoot: options.projectRoot,
7373
blacklistRE: blacklist(false),

0 commit comments

Comments
 (0)