Skip to content

Commit 65e5ee3

Browse files
author
clayallsopp
committed
Remove unneessary permissions, fixes #5886
1 parent 6336e4d commit 65e5ee3

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

local-cli/templates/HelloWorld/android/app/src/main/AndroidManifest.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,12 @@
66
<uses-permission android:name="android.permission.INTERNET" />
77
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
88

9+
<!-- These permissions are added implicitly by android-jsc, see https://github.com/facebook/android-jsc/pull/12 -->
10+
<!-- The following lines can be removed after android-jsc is updated in react-native -->
11+
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" tools:node="remove" />
12+
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:node="remove" />
13+
<uses-permission android:name="android.permission.READ_PHONE_STATE" tools:node="remove"/>
14+
915
<uses-sdk
1016
android:minSdkVersion="16"
1117
android:targetSdkVersion="22" />
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<manifest
2+
xmlns:android="http://schemas.android.com/apk/res/android"
3+
xmlns:tools="http://schemas.android.com/tools"
4+
>
5+
6+
<!-- These are added by React Native for debug mode, but aren't needed in release mode -->
7+
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW" tools:node="remove" />
8+
</manifest>

0 commit comments

Comments
 (0)