Add TurboModule Setup Metrics

Author: a-dilettante

React/Base/RCTBridge.h

@@ -53,7 +53,14 @@ RCT_EXTERN NSString *const RCTDidInitializeModuleNotification;
  * `RCTDidSetupModuleNotificationModuleNameKey` key will contain a reference to the module name and
  * `RCTDidSetupModuleNotificationSetupTimeKey` will contain the setup time in ms.
  */
-RCT_EXTERN NSString *const RCTDidSetupModuleNotification;
+RCT_EXTERN NSString *const RCTDidSetupNativeModuleNotification;
+
+/**
+ * This notification fires each time a turbo module is setup after it is initialized. The
+ * `RCTDidSetupModuleNotificationModuleNameKey` key will contain a reference to the module name and
+ * `RCTDidSetupModuleNotificationSetupTimeKey` will contain the setup time in ms.
+ */
+RCT_EXTERN NSString *const RCTDidSetupTurboModuleNotification;
 
 /**
  * Key for the module name (NSString) in the

React/Base/RCTBridge.m

@@ -27,7 +27,8 @@
 NSString *const RCTJavaScriptDidLoadNotification = @"RCTJavaScriptDidLoadNotification";
 NSString *const RCTJavaScriptDidFailToLoadNotification = @"RCTJavaScriptDidFailToLoadNotification";
 NSString *const RCTDidInitializeModuleNotification = @"RCTDidInitializeModuleNotification";
-NSString *const RCTDidSetupModuleNotification = @"RCTDidSetupModuleNotification";
+NSString *const RCTDidSetupNativeModuleNotification = @"RCTDidSetupNativeModuleNotification";
+NSString *const RCTDidSetupTurboModuleNotification = @"RCTDidSetupTurboModuleNotification";
 NSString *const RCTDidSetupModuleNotificationModuleNameKey = @"moduleName";
 NSString *const RCTDidSetupModuleNotificationSetupTimeKey = @"setupTime";
 NSString *const RCTBridgeWillReloadNotification = @"RCTBridgeWillReloadNotification";

React/Base/RCTPerformanceLogger.h

@@ -21,6 +21,7 @@ typedef NS_ENUM(NSUInteger, RCTPLTag) {
   RCTPLNativeModulePrepareConfig,
   RCTPLNativeModuleMainThreadUsesCount,
   RCTPLNativeModuleSetup,
+  RCTPLTurboModuleSetup,
   RCTPLJSCWrapperOpenLibrary,
   RCTPLBridgeStartup,
   RCTPLTTI,

React/Base/RCTPerformanceLogger.m

@@ -42,6 +42,7 @@ - (instancetype)init
       @"NativeModuleInjectConfig",
       @"NativeModuleMainThreadUsesCount",
       @"NativeModuleSetup",
+      @"TurboModuleSetup",
       @"JSCWrapperOpenLibrary",
       @"JSCExecutorSetup",
       @"BridgeStartup",

React/CxxBridge/RCTCxxBridge.mm

@@ -103,7 +103,7 @@ static void notifyAboutModuleSetup(RCTPerformanceLogger *performanceLogger, cons
   NSString *moduleName = [[NSString alloc] initWithUTF8String:tag];
   if (moduleName) {
     int64_t setupTime = [performanceLogger durationForTag:RCTPLNativeModuleSetup];
-    [[NSNotificationCenter defaultCenter] postNotificationName:RCTDidSetupModuleNotification
+    [[NSNotificationCenter defaultCenter] postNotificationName:RCTDidSetupNativeModuleNotification
                                                         object:nil
                                                       userInfo:@{
                                                                  RCTDidSetupModuleNotificationModuleNameKey: moduleName,

ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm

@@ -10,6 +10,7 @@
 #import <cassert>
 
 #import <React/RCTBridge+Private.h>
+#import <React/RCTPerformanceLogger.h>
 #import <React/RCTBridgeModule.h>
 #import <React/RCTCxxModule.h>
 #import <React/RCTLog.h>
@@ -67,19 +68,47 @@ - (instancetype)initWithRuntime:(jsi::Runtime *)runtime
 
       __strong __typeof(self) strongSelf = weakSelf;
 
+      auto moduleName = name.c_str();
+      bool didFindModuleInCacheBeforeCreation = strongSelf->_turboModuleCache.find(moduleName) != strongSelf->_turboModuleCache.end();
+      if (!didFindModuleInCacheBeforeCreation) {
+        [strongSelf->_bridge.performanceLogger markStartForTag:RCTPLTurboModuleSetup];
+      }
+
       /**
        * By default, all TurboModules are long-lived.
        * Additionally, if a TurboModule with the name `name` isn't found, then we
        * trigger an assertion failure.
        */
-      return [strongSelf provideTurboModule: name.c_str()];
+
+      std::shared_ptr<react::TurboModule> turboModule = [strongSelf provideTurboModule:moduleName];
+
+      bool didFindModuleInCacheAfterCreation = strongSelf->_turboModuleCache.find(moduleName) != strongSelf->_turboModuleCache.end();
+      if (!didFindModuleInCacheBeforeCreation  && didFindModuleInCacheAfterCreation) {
+        [strongSelf->_bridge.performanceLogger markStopForTag:RCTPLTurboModuleSetup];
+        [strongSelf notifyAboutTurboModuleSetup:moduleName];
+      }
+
+      return turboModule;
     };
 
     _binding = std::make_shared<react::TurboModuleBinding>(moduleProvider);
   }
   return self;
 }
 
+- (void)notifyAboutTurboModuleSetup:(const char*)name {
+    NSString *moduleName = [[NSString alloc] initWithUTF8String:name];
+    if (moduleName) {
+      int64_t setupTime = [self->_bridge.performanceLogger durationForTag:RCTPLTurboModuleSetup];
+      [[NSNotificationCenter defaultCenter] postNotificationName:RCTDidSetupTurboModuleNotification
+                                                          object:nil
+                                                        userInfo:@{
+                                                                  RCTDidSetupModuleNotificationModuleNameKey: moduleName,
+                                                                  RCTDidSetupModuleNotificationSetupTimeKey: @(setupTime)
+                                                                  }];
+    }
+}
+
 /**
  * Given a name for a TurboModule, return a C++ object which is the instance
  * of that TurboModule C++ class. This class wraps the TurboModule's ObjC instance.