Skip to content

Commit eaafc26

Browse files
Riccardo Cipolleschifacebook-github-bot
authored andcommitted
Restore envinfo for test_windows (#38062)
Summary: We had to disable the envinfo command on test_windows to get the CI back to green. The reason why it started failing is because they released 7.9.0 which does not seem to have the executable on Windows, so `npx` fails to find what to run. This fix restore the command in a way that it should display the envinfo using an older version of the package. I also added a task to come back to this periodically. ## Changelog: [Internal] - Restore envinfo on windows Pull Request resolved: #38062 Test Plan: - CircleCI: test_windows stays green Reviewed By: cortinico Differential Revision: D47016995 Pulled By: cipolleschi fbshipit-source-id: 368367caed7ea49d7419475580a39f9406c54757
1 parent 772c9eb commit eaafc26

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

.circleci/config.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1067,9 +1067,15 @@ jobs:
10671067
name: Enable Yarn with corepack
10681068
command: corepack enable
10691069

1070-
# - run:
1071-
# name: Display Environment info
1072-
# command: npx envinfo@latest
1070+
# it looks like that, last week, envinfo released version 7.9.0 which does not works
1071+
# with Windows. I have opened an issue here: https://github.com/tabrindle/envinfo/issues/238
1072+
# TODO: T156811874 - Revert this to npx envinfo@latest when the issue is addressed
1073+
- run:
1074+
name: Display Environment info
1075+
command: |
1076+
npm install -g envinfo
1077+
envinfo -v
1078+
envinfo
10731079
10741080
- restore_cache:
10751081
keys:

0 commit comments

Comments
 (0)