fix android lint errors

Author: chirag04

ReactAndroid/src/main/java/com/facebook/react/modules/dialog/AlertFragment.java

@@ -28,16 +28,7 @@ public class AlertFragment extends DialogFragment implements DialogInterface.OnC
   /* package */ static final String ARG_BUTTON_NEUTRAL = "button_neutral";
   /* package */ static final String ARG_ITEMS = "items";
 
-  private final @Nullable DialogModule.AlertFragmentListener mListener;
-
-  public AlertFragment() {
-      mListener = null;
-  }
-
-  public AlertFragment(@Nullable DialogModule.AlertFragmentListener listener, Bundle arguments) {
-    mListener = listener;
-    setArguments(arguments);
-  }
+  private @Nullable DialogModule.AlertFragmentListener mListener;
 
   public static Dialog createDialog(
       Context activityContext, Bundle arguments, DialogInterface.OnClickListener fragment) {
@@ -84,4 +75,8 @@ public void onDismiss(DialogInterface dialog) {
       mListener.onDismiss(dialog);
     }
   }
+
+  /*package*/ void setAlertFragmentListener(@Nullable DialogModule.AlertFragmentListener alertFragmentListener) {
+    mListener = alertFragmentListener;
+  }
 }

ReactAndroid/src/main/java/com/facebook/react/modules/dialog/DialogModule.java

@@ -131,7 +131,9 @@ public void showNewAlert(boolean isInForeground, Bundle arguments, Callback acti
           actionCallback != null ? new AlertFragmentListener(actionCallback) : null;
 
       if (isUsingSupportLibrary()) {
-        SupportAlertFragment alertFragment = new SupportAlertFragment(actionListener, arguments);
+        SupportAlertFragment alertFragment = new SupportAlertFragment();
+        alertFragment.setArguments(arguments);
+        alertFragment.setAlertFragmentListener(actionListener);
         if (isInForeground) {
           if (arguments.containsKey(KEY_CANCELABLE)) {
             alertFragment.setCancelable(arguments.getBoolean(KEY_CANCELABLE));
@@ -141,7 +143,10 @@ public void showNewAlert(boolean isInForeground, Bundle arguments, Callback acti
           mFragmentToShow = alertFragment;
         }
       } else {
-        AlertFragment alertFragment = new AlertFragment(actionListener, arguments);
+        AlertFragment alertFragment = new AlertFragment();
+        alertFragment.setArguments(arguments);
+        alertFragment.setAlertFragmentListener(actionListener);
+
         if (isInForeground) {
           if (arguments.containsKey(KEY_CANCELABLE)) {
             alertFragment.setCancelable(arguments.getBoolean(KEY_CANCELABLE));

ReactAndroid/src/main/java/com/facebook/react/modules/dialog/SupportAlertFragment.java

@@ -21,16 +21,7 @@
  */
 public class SupportAlertFragment extends DialogFragment implements DialogInterface.OnClickListener {
 
-  private final @Nullable DialogModule.AlertFragmentListener mListener;
-
-  public SupportAlertFragment() {
-      mListener = null;
-  }
-
-  public SupportAlertFragment(@Nullable DialogModule.AlertFragmentListener listener, Bundle arguments) {
-    mListener = listener;
-    setArguments(arguments);
-  }
+  private @Nullable DialogModule.AlertFragmentListener mListener;
 
   @Override
   public Dialog onCreateDialog(Bundle savedInstanceState) {
@@ -51,4 +42,8 @@ public void onDismiss(DialogInterface dialog) {
       mListener.onDismiss(dialog);
     }
   }
+
+  /*package*/ void setAlertFragmentListener(@Nullable DialogModule.AlertFragmentListener alertFragmentListener) {
+    mListener = alertFragmentListener;
+  }
 }