Skip to content

Commit 9dca7fd

Browse files
committed
Remove ReactFabricPublicInstance and used definition from ReactNativePrivateInterface (#26437)
## Summary Now that React Native owns the definition for public instances in Fabric and ReactNativePrivateInterface provides the methods to create instances and access private fields (see facebook/react-native#36570), we can remove the definitions from React. After this PR, React Native public instances will be opaque types for React and it will only handle their creation but not their definition. This will make RN similar to DOM in how public instances are handled. This is a new version of #26418 which was closed without merging. ## How did you test this change? * Existing tests. * Manually synced the changes in this PR to React Native and tested it end to end in Meta's infra. DiffTrain build for commit 9c54b29.
1 parent b87cdfd commit 9dca7fd

File tree

13 files changed

+20783
-21076
lines changed

13 files changed

+20783
-21076
lines changed

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23649,7 +23649,7 @@ function createFiberRoot(
2364923649
return root;
2365023650
}
2365123651

23652-
var ReactVersion = "18.3.0-next-f77099b6f-20230322";
23652+
var ReactVersion = "18.3.0-next-9c54b29b4-20230322";
2365323653

2365423654
// Might add PROFILE later.
2365523655

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8570,7 +8570,7 @@ var devToolsConfig$jscomp$inline_1029 = {
85708570
throw Error("TestRenderer does not support findFiberByHostInstance()");
85718571
},
85728572
bundleType: 0,
8573-
version: "18.3.0-next-f77099b6f-20230322",
8573+
version: "18.3.0-next-9c54b29b4-20230322",
85748574
rendererPackageName: "react-test-renderer"
85758575
};
85768576
var internals$jscomp$inline_1217 = {
@@ -8601,7 +8601,7 @@ var internals$jscomp$inline_1217 = {
86018601
scheduleRoot: null,
86028602
setRefreshHandler: null,
86038603
getCurrentFiber: null,
8604-
reconcilerVersion: "18.3.0-next-f77099b6f-20230322"
8604+
reconcilerVersion: "18.3.0-next-9c54b29b4-20230322"
86058605
};
86068606
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
86078607
var hook$jscomp$inline_1218 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8995,7 +8995,7 @@ var devToolsConfig$jscomp$inline_1072 = {
89958995
throw Error("TestRenderer does not support findFiberByHostInstance()");
89968996
},
89978997
bundleType: 0,
8998-
version: "18.3.0-next-f77099b6f-20230322",
8998+
version: "18.3.0-next-9c54b29b4-20230322",
89998999
rendererPackageName: "react-test-renderer"
90009000
};
90019001
var internals$jscomp$inline_1258 = {
@@ -9026,7 +9026,7 @@ var internals$jscomp$inline_1258 = {
90269026
scheduleRoot: null,
90279027
setRefreshHandler: null,
90289028
getCurrentFiber: null,
9029-
reconcilerVersion: "18.3.0-next-f77099b6f-20230322"
9029+
reconcilerVersion: "18.3.0-next-9c54b29b4-20230322"
90309030
};
90319031
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
90329032
var hook$jscomp$inline_1259 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-dev.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-next-f77099b6f-20230322";
30+
var ReactVersion = "18.3.0-next-9c54b29b4-20230322";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-prod.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -639,4 +639,4 @@ exports.useSyncExternalStore = function (
639639
);
640640
};
641641
exports.useTransition = useTransition;
642-
exports.version = "18.3.0-next-f77099b6f-20230322";
642+
exports.version = "18.3.0-next-9c54b29b4-20230322";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/cjs/React-profiling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -642,7 +642,7 @@ exports.useSyncExternalStore = function (
642642
);
643643
};
644644
exports.useTransition = useTransition;
645-
exports.version = "18.3.0-next-f77099b6f-20230322";
645+
exports.version = "18.3.0-next-9c54b29b4-20230322";
646646

647647
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
648648
if (
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
f77099b6f1ccc658eff3467c6b9337e1b77ec854
1+
9c54b29b44d24f8f8090da9c7ebf569747a444df

0 commit comments

Comments
 (0)