Skip to content

Commit c53145c

Browse files
committed
Remove enableRefAsProp feature flag (#30346)
The flag is fully rolled out. DiffTrain build for [07aa494](07aa494)
1 parent eeb3328 commit c53145c

25 files changed

+1116
-1307
lines changed

compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.0.0-native-fb-ea3ac586-20241031
1+
19.0.0-native-fb-07aa4944-20241104

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-dev.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<fe2a5887890fd9ac0c7e12bbbe65fde3>>
10+
* @generated SignedSource<<dcb2fe275d42581e440eab19f4f48f20>>
1111
*/
1212

1313
"use strict";
@@ -420,5 +420,5 @@ __DEV__ &&
420420
exports.useFormStatus = function () {
421421
return resolveDispatcher().useHostTransitionStatus();
422422
};
423-
exports.version = "19.0.0-native-fb-ea3ac586-20241031";
423+
exports.version = "19.0.0-native-fb-07aa4944-20241104";
424424
})();

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<1cb77e72c96250d4d97fa3f50697ea38>>
10+
* @generated SignedSource<<772ea4b36b8b994c3826632a6ac860ea>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.0.0-native-fb-ea3ac586-20241031";
206+
exports.version = "19.0.0-native-fb-07aa4944-20241104";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOM-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<1cb77e72c96250d4d97fa3f50697ea38>>
10+
* @generated SignedSource<<772ea4b36b8b994c3826632a6ac860ea>>
1111
*/
1212

1313
"use strict";
@@ -203,4 +203,4 @@ exports.useFormState = function (action, initialState, permalink) {
203203
exports.useFormStatus = function () {
204204
return ReactSharedInternals.H.useHostTransitionStatus();
205205
};
206-
exports.version = "19.0.0-native-fb-ea3ac586-20241031";
206+
exports.version = "19.0.0-native-fb-07aa4944-20241104";

compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-dom/cjs/ReactDOMClient-dev.js

Lines changed: 80 additions & 90 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<5c3370bf9d23dea134827436a14c995a>>
10+
* @generated SignedSource<<abdb2c36b62c6c0ae8f60c39c966e5d9>>
1111
*/
1212

1313
/*
@@ -4568,9 +4568,9 @@ __DEV__ &&
45684568
null === thenableState$1 && (thenableState$1 = createThenableState());
45694569
return trackUsedThenable(thenableState$1, thenable, index);
45704570
}
4571-
function coerceRef(returnFiber, current, workInProgress, element) {
4572-
returnFiber = element.props.ref;
4573-
workInProgress.ref = void 0 !== returnFiber ? returnFiber : null;
4571+
function coerceRef(workInProgress, element) {
4572+
element = element.props.ref;
4573+
workInProgress.ref = void 0 !== element ? element : null;
45744574
}
45754575
function throwOnInvalidObjectType(returnFiber, newChild) {
45764576
if (newChild.$$typeof === REACT_LEGACY_ELEMENT_TYPE)
@@ -4719,18 +4719,18 @@ __DEV__ &&
47194719
callLazyInitInDEV(elementType) === current.type))
47204720
)
47214721
return (
4722-
(lanes = useFiber(current, element.props)),
4723-
coerceRef(returnFiber, current, lanes, element),
4724-
(lanes.return = returnFiber),
4725-
(lanes._debugOwner = element._owner),
4726-
(lanes._debugInfo = currentDebugInfo),
4727-
lanes
4722+
(current = useFiber(current, element.props)),
4723+
coerceRef(current, element),
4724+
(current.return = returnFiber),
4725+
(current._debugOwner = element._owner),
4726+
(current._debugInfo = currentDebugInfo),
4727+
current
47284728
);
4729-
lanes = createFiberFromElement(element, returnFiber.mode, lanes);
4730-
coerceRef(returnFiber, current, lanes, element);
4731-
lanes.return = returnFiber;
4732-
lanes._debugInfo = currentDebugInfo;
4733-
return lanes;
4729+
current = createFiberFromElement(element, returnFiber.mode, lanes);
4730+
coerceRef(current, element);
4731+
current.return = returnFiber;
4732+
current._debugInfo = currentDebugInfo;
4733+
return current;
47344734
}
47354735
function updatePortal(returnFiber, current, portal, lanes) {
47364736
if (
@@ -4795,7 +4795,7 @@ __DEV__ &&
47954795
returnFiber.mode,
47964796
lanes
47974797
)),
4798-
coerceRef(returnFiber, null, lanes, newChild),
4798+
coerceRef(lanes, newChild),
47994799
(lanes.return = returnFiber),
48004800
(returnFiber = pushDebugInfo(newChild._debugInfo)),
48014801
(lanes._debugInfo = currentDebugInfo),
@@ -5310,80 +5310,72 @@ __DEV__ &&
53105310
case REACT_ELEMENT_TYPE:
53115311
var prevDebugInfo = pushDebugInfo(newChild._debugInfo);
53125312
a: {
5313-
for (
5314-
var key = newChild.key, child = currentFirstChild;
5315-
null !== child;
5316-
5317-
) {
5318-
if (child.key === key) {
5313+
for (var key = newChild.key; null !== currentFirstChild; ) {
5314+
if (currentFirstChild.key === key) {
53195315
key = newChild.type;
53205316
if (key === REACT_FRAGMENT_TYPE) {
5321-
if (7 === child.tag) {
5322-
deleteRemainingChildren(returnFiber, child.sibling);
5323-
currentFirstChild = useFiber(
5324-
child,
5325-
newChild.props.children
5317+
if (7 === currentFirstChild.tag) {
5318+
deleteRemainingChildren(
5319+
returnFiber,
5320+
currentFirstChild.sibling
53265321
);
5327-
currentFirstChild.return = returnFiber;
5328-
currentFirstChild._debugOwner = newChild._owner;
5329-
currentFirstChild._debugInfo = currentDebugInfo;
5330-
validateFragmentProps(
5331-
newChild,
5322+
lanes = useFiber(
53325323
currentFirstChild,
5333-
returnFiber
5324+
newChild.props.children
53345325
);
5335-
returnFiber = currentFirstChild;
5326+
lanes.return = returnFiber;
5327+
lanes._debugOwner = newChild._owner;
5328+
lanes._debugInfo = currentDebugInfo;
5329+
validateFragmentProps(newChild, lanes, returnFiber);
5330+
returnFiber = lanes;
53365331
break a;
53375332
}
53385333
} else if (
5339-
child.elementType === key ||
5340-
isCompatibleFamilyForHotReloading(child, newChild) ||
5334+
currentFirstChild.elementType === key ||
5335+
isCompatibleFamilyForHotReloading(
5336+
currentFirstChild,
5337+
newChild
5338+
) ||
53415339
("object" === typeof key &&
53425340
null !== key &&
53435341
key.$$typeof === REACT_LAZY_TYPE &&
5344-
callLazyInitInDEV(key) === child.type)
5342+
callLazyInitInDEV(key) === currentFirstChild.type)
53455343
) {
5346-
deleteRemainingChildren(returnFiber, child.sibling);
5347-
currentFirstChild = useFiber(child, newChild.props);
5348-
coerceRef(
5344+
deleteRemainingChildren(
53495345
returnFiber,
5350-
child,
5351-
currentFirstChild,
5352-
newChild
5346+
currentFirstChild.sibling
53535347
);
5354-
currentFirstChild.return = returnFiber;
5355-
currentFirstChild._debugOwner = newChild._owner;
5356-
currentFirstChild._debugInfo = currentDebugInfo;
5357-
returnFiber = currentFirstChild;
5348+
lanes = useFiber(currentFirstChild, newChild.props);
5349+
coerceRef(lanes, newChild);
5350+
lanes.return = returnFiber;
5351+
lanes._debugOwner = newChild._owner;
5352+
lanes._debugInfo = currentDebugInfo;
5353+
returnFiber = lanes;
53585354
break a;
53595355
}
5360-
deleteRemainingChildren(returnFiber, child);
5356+
deleteRemainingChildren(returnFiber, currentFirstChild);
53615357
break;
5362-
} else deleteChild(returnFiber, child);
5363-
child = child.sibling;
5358+
} else deleteChild(returnFiber, currentFirstChild);
5359+
currentFirstChild = currentFirstChild.sibling;
53645360
}
53655361
newChild.type === REACT_FRAGMENT_TYPE
5366-
? ((currentFirstChild = createFiberFromFragment(
5362+
? ((lanes = createFiberFromFragment(
53675363
newChild.props.children,
53685364
returnFiber.mode,
53695365
lanes,
53705366
newChild.key
53715367
)),
5372-
(currentFirstChild.return = returnFiber),
5373-
(currentFirstChild._debugOwner = returnFiber),
5374-
(currentFirstChild._debugInfo = currentDebugInfo),
5375-
validateFragmentProps(
5376-
newChild,
5377-
currentFirstChild,
5378-
returnFiber
5379-
),
5380-
(returnFiber = currentFirstChild))
5368+
(lanes.return = returnFiber),
5369+
(lanes._debugOwner = returnFiber),
5370+
(lanes._debugInfo = currentDebugInfo),
5371+
validateFragmentProps(newChild, lanes, returnFiber),
5372+
(returnFiber = lanes))
53815373
: ((lanes = createFiberFromElement(
53825374
newChild,
53835375
returnFiber.mode,
53845376
lanes
53855377
)),
5386-
coerceRef(returnFiber, currentFirstChild, lanes, newChild),
5378+
coerceRef(lanes, newChild),
53875379
(lanes.return = returnFiber),
53885380
(lanes._debugInfo = currentDebugInfo),
53895381
(returnFiber = lanes));
@@ -5411,12 +5403,12 @@ __DEV__ &&
54115403
returnFiber,
54125404
currentFirstChild.sibling
54135405
);
5414-
currentFirstChild = useFiber(
5406+
lanes = useFiber(
54155407
currentFirstChild,
54165408
prevDebugInfo.children || []
54175409
);
5418-
currentFirstChild.return = returnFiber;
5419-
returnFiber = currentFirstChild;
5410+
lanes.return = returnFiber;
5411+
returnFiber = lanes;
54205412
break a;
54215413
} else {
54225414
deleteRemainingChildren(returnFiber, currentFirstChild);
@@ -5425,13 +5417,13 @@ __DEV__ &&
54255417
else deleteChild(returnFiber, currentFirstChild);
54265418
currentFirstChild = currentFirstChild.sibling;
54275419
}
5428-
currentFirstChild = createFiberFromPortal(
5420+
lanes = createFiberFromPortal(
54295421
prevDebugInfo,
54305422
returnFiber.mode,
54315423
lanes
54325424
);
5433-
currentFirstChild.return = returnFiber;
5434-
returnFiber = currentFirstChild;
5425+
lanes.return = returnFiber;
5426+
returnFiber = lanes;
54355427
}
54365428
return placeSingleChild(returnFiber);
54375429
case REACT_LAZY_TYPE:
@@ -5462,26 +5454,27 @@ __DEV__ &&
54625454
);
54635455
if (getIteratorFn(newChild)) {
54645456
prevDebugInfo = pushDebugInfo(newChild._debugInfo);
5465-
child = getIteratorFn(newChild);
5466-
if ("function" !== typeof child)
5457+
key = getIteratorFn(newChild);
5458+
if ("function" !== typeof key)
54675459
throw Error(
54685460
"An object is not an iterable. This error is likely caused by a bug in React. Please file an issue."
54695461
);
5470-
key = child.call(newChild);
5471-
if (key === newChild) {
5462+
var newChildren = key.call(newChild);
5463+
if (newChildren === newChild) {
54725464
if (
54735465
0 !== returnFiber.tag ||
54745466
"[object GeneratorFunction]" !==
54755467
Object.prototype.toString.call(returnFiber.type) ||
5476-
"[object Generator]" !== Object.prototype.toString.call(key)
5468+
"[object Generator]" !==
5469+
Object.prototype.toString.call(newChildren)
54775470
)
54785471
didWarnAboutGenerators ||
54795472
error$jscomp$0(
54805473
"Using Iterators as children is unsupported and will likely yield unexpected results because enumerating a generator mutates it. You may convert it to an array with `Array.from()` or the `[...spread]` operator before rendering. You can also use an Iterable that can iterate multiple times over the same items."
54815474
),
54825475
(didWarnAboutGenerators = !0);
54835476
} else
5484-
newChild.entries !== child ||
5477+
newChild.entries !== key ||
54855478
didWarnAboutMaps ||
54865479
(error$jscomp$0(
54875480
"Using Maps as children is not supported. Use an array of keyed ReactElements instead."
@@ -5490,7 +5483,7 @@ __DEV__ &&
54905483
returnFiber = reconcileChildrenIterator(
54915484
returnFiber,
54925485
currentFirstChild,
5493-
key,
5486+
newChildren,
54945487
lanes
54955488
);
54965489
currentDebugInfo = prevDebugInfo;
@@ -5529,22 +5522,19 @@ __DEV__ &&
55295522
returnFiber,
55305523
currentFirstChild.sibling
55315524
),
5532-
(currentFirstChild = useFiber(
5533-
currentFirstChild,
5534-
prevDebugInfo
5535-
)),
5536-
(currentFirstChild.return = returnFiber),
5537-
(returnFiber = currentFirstChild))
5525+
(lanes = useFiber(currentFirstChild, prevDebugInfo)),
5526+
(lanes.return = returnFiber),
5527+
(returnFiber = lanes))
55385528
: (deleteRemainingChildren(returnFiber, currentFirstChild),
5539-
(currentFirstChild = createFiberFromText(
5529+
(lanes = createFiberFromText(
55405530
prevDebugInfo,
55415531
returnFiber.mode,
55425532
lanes
55435533
)),
5544-
(currentFirstChild.return = returnFiber),
5545-
(currentFirstChild._debugOwner = returnFiber),
5546-
(currentFirstChild._debugInfo = currentDebugInfo),
5547-
(returnFiber = currentFirstChild)),
5534+
(lanes.return = returnFiber),
5535+
(lanes._debugOwner = returnFiber),
5536+
(lanes._debugInfo = currentDebugInfo),
5537+
(returnFiber = lanes)),
55485538
placeSingleChild(returnFiber)
55495539
);
55505540
"function" === typeof newChild &&
@@ -25347,11 +25337,11 @@ __DEV__ &&
2534725337
};
2534825338
(function () {
2534925339
var isomorphicReactPackageVersion = React.version;
25350-
if ("19.0.0-native-fb-ea3ac586-20241031" !== isomorphicReactPackageVersion)
25340+
if ("19.0.0-native-fb-07aa4944-20241104" !== isomorphicReactPackageVersion)
2535125341
throw Error(
2535225342
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
2535325343
(isomorphicReactPackageVersion +
25354-
"\n - react-dom: 19.0.0-native-fb-ea3ac586-20241031\nLearn more: https://react.dev/warnings/version-mismatch")
25344+
"\n - react-dom: 19.0.0-native-fb-07aa4944-20241104\nLearn more: https://react.dev/warnings/version-mismatch")
2535525345
);
2535625346
})();
2535725347
("function" === typeof Map &&
@@ -25388,11 +25378,11 @@ __DEV__ &&
2538825378
!(function () {
2538925379
var internals = {
2539025380
bundleType: 1,
25391-
version: "19.0.0-native-fb-ea3ac586-20241031",
25381+
version: "19.0.0-native-fb-07aa4944-20241104",
2539225382
rendererPackageName: "react-dom",
2539325383
currentDispatcherRef: ReactSharedInternals,
2539425384
findFiberByHostInstance: getClosestInstanceFromNode,
25395-
reconcilerVersion: "19.0.0-native-fb-ea3ac586-20241031"
25385+
reconcilerVersion: "19.0.0-native-fb-07aa4944-20241104"
2539625386
};
2539725387
internals.overrideHookState = overrideHookState;
2539825388
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -25536,5 +25526,5 @@ __DEV__ &&
2553625526
listenToAllSupportedEvents(container);
2553725527
return new ReactDOMHydrationRoot(initialChildren);
2553825528
};
25539-
exports.version = "19.0.0-native-fb-ea3ac586-20241031";
25529+
exports.version = "19.0.0-native-fb-07aa4944-20241104";
2554025530
})();

0 commit comments

Comments
 (0)