Make guarded callback more local for mutation phase

gaearon · gaearon · commit d1e7f28d8382 · 2021-06-10T20:26:38.000+01:00
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js
@@ -2208,6 +2208,7 @@ function commitMutationEffects_begin(root: FiberRoot) {
 function commitMutationEffects_complete(root: FiberRoot) {
   while (nextEffect !== null) {
     const fiber = nextEffect;
+    if (fiber.flags !== NoFlags) {
       if (__DEV__) {
         setCurrentDebugFiberInDEV(fiber);
         invokeGuardedCallback(
@@ -2229,6 +2230,7 @@ function commitMutationEffects_complete(root: FiberRoot) {
           captureCommitPhaseError(fiber, fiber.return, error);
         }
       }
+    }
 
     const sibling = fiber.sibling;
     if (sibling !== null) {

Original file line number	Diff line number	Diff line change
`@@ -2208,6 +2208,7 @@ function commitMutationEffects_begin(root: FiberRoot) {`
`2208`	`2208`	`function commitMutationEffects_complete(root: FiberRoot) {`
`2209`	`2209`	`while (nextEffect !== null) {`
`2210`	`2210`	`const fiber = nextEffect;`
	`2211`	`+ if (fiber.flags !== NoFlags) {`
`2211`	`2212`	`if (__DEV__) {`
`2212`	`2213`	`setCurrentDebugFiberInDEV(fiber);`
`2213`	`2214`	`invokeGuardedCallback(`
`@@ -2229,6 +2230,7 @@ function commitMutationEffects_complete(root: FiberRoot) {`
`2229`	`2230`	`captureCommitPhaseError(fiber, fiber.return, error);`
`2230`	`2231`	`}`
`2231`	`2232`	`}`
	`2233`	`+ }`
`2232`	`2234`
`2233`	`2235`	`const sibling = fiber.sibling;`
`2234`	`2236`	`if (sibling !== null) {`