Skip to content

Commit d9b663c

Browse files
committed
Limit the meaning of "custom element" to not include is (#26524)
This PR has a bunch of surrounding refactoring. See individual commits. The main change is that we no longer special case `typeof is === 'string'` as a special case according to the `enableCustomElementPropertySupport` flag. Effectively this means that you can't use custom properties/events, other than the ones React knows about on `<input is="my-input">` extensions. This is unfortunate but there's too many paths that are forked in inconsistent ways since we fork based on tag name. I think __the solution is to let all React elements set unknown properties/events in the same way as this flag__ but that's a bigger change than this flag implies. Since `is` is not universally supported yet anyway, this doesn't seem like a huge loss. Attributes still work. We still support passing the `is` prop and turn that into the appropriate createElement call. @josepharhar DiffTrain build for [43a70a6](43a70a6)
1 parent dd1749c commit d9b663c

22 files changed

+1477
-1834
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1a1d61fed98a02c9b1bac029d0bc11c3e4db896d
1+
43a70a610dd2cc298ab5592deebfbf8f7bbac127

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-modern-8f5a57f2";
30+
var ReactVersion = "18.3.0-www-modern-b298fcd9";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
6969
return self;
7070
}
7171

72-
var ReactVersion = "18.3.0-www-classic-26d7a5d5";
72+
var ReactVersion = "18.3.0-www-classic-8643ce3a";
7373

7474
var LegacyRoot = 0;
7575
var ConcurrentRoot = 1;

compiled/facebook-www/ReactART-prod.modern.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9688,7 +9688,7 @@ var slice = Array.prototype.slice,
96889688
return null;
96899689
},
96909690
bundleType: 0,
9691-
version: "18.3.0-www-modern-132fb191",
9691+
version: "18.3.0-www-modern-b8a2f36f",
96929692
rendererPackageName: "react-art"
96939693
};
96949694
var internals$jscomp$inline_1304 = {
@@ -9719,7 +9719,7 @@ var internals$jscomp$inline_1304 = {
97199719
scheduleRoot: null,
97209720
setRefreshHandler: null,
97219721
getCurrentFiber: null,
9722-
reconcilerVersion: "18.3.0-www-modern-132fb191"
9722+
reconcilerVersion: "18.3.0-www-modern-b8a2f36f"
97239723
};
97249724
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
97259725
var hook$jscomp$inline_1305 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

0 commit comments

Comments
 (0)