Skip to content

Commit fc07195

Browse files
author
Brian Vaughn
committed
Fixed goofy short-circuit bug
1 parent cd3b12e commit fc07195

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

packages/react-devtools-scheduling-profiler/src/content-views/ComponentMeasuresView.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,12 @@ export class ComponentMeasuresView extends View {
7171
_drawSingleReactComponentMeasure(
7272
context: CanvasRenderingContext2D,
7373
rect: Rect,
74-
event: ReactComponentMeasure,
74+
componentMeasure: ReactComponentMeasure,
7575
scaleFactor: number,
7676
showHoverHighlight: boolean,
7777
): boolean {
7878
const {frame} = this;
79-
const {componentName, duration, timestamp, warning} = event;
79+
const {componentName, duration, timestamp, warning} = componentMeasure;
8080

8181
const xStart = timestampToPosition(timestamp, scaleFactor, frame);
8282
const xStop = timestampToPosition(timestamp + duration, scaleFactor, frame);
@@ -146,14 +146,13 @@ export class ComponentMeasuresView extends View {
146146
let didDrawMeasure = false;
147147
componentMeasures.forEach(componentMeasure => {
148148
didDrawMeasure =
149-
didDrawMeasure ||
150149
this._drawSingleReactComponentMeasure(
151150
context,
152151
visibleArea,
153152
componentMeasure,
154153
scaleFactor,
155154
componentMeasure === _hoveredComponentMeasure,
156-
);
155+
) || didDrawMeasure;
157156
});
158157

159158
if (!didDrawMeasure) {

0 commit comments

Comments
 (0)