Avoid -Wmaybe-uninitialized when compiling with gcc -O1

hebasto · hebasto · commit a6ca76cdf2a3 · 2023-06-28T07:45:57.000+01:00
diff --git a/src/ecmult_impl.h b/src/ecmult_impl.h
@@ -288,7 +288,9 @@ static void secp256k1_ecmult_strauss_wnaf(const struct secp256k1_strauss_state *
     }
 
     /* Bring them to the same Z denominator. */
-    secp256k1_ge_table_set_globalz(ECMULT_TABLE_SIZE(WINDOW_A) * no, state->pre_a, state->aux);
+    if (no) {
+        secp256k1_ge_table_set_globalz(ECMULT_TABLE_SIZE(WINDOW_A) * no, state->pre_a, state->aux);
+    }
 
     for (np = 0; np < no; ++np) {
         for (i = 0; i < ECMULT_TABLE_SIZE(WINDOW_A); i++) {

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,9 @@ static void secp256k1_ecmult_strauss_wnaf(const struct secp256k1_strauss_state *`
`288`	`288`	`}`
`289`	`289`
`290`	`290`	`/* Bring them to the same Z denominator. */`
`291`		`- secp256k1_ge_table_set_globalz(ECMULT_TABLE_SIZE(WINDOW_A) * no, state->pre_a, state->aux);`
	`291`	`+ if (no) {`
	`292`	`+ secp256k1_ge_table_set_globalz(ECMULT_TABLE_SIZE(WINDOW_A) * no, state->pre_a, state->aux);`
	`293`	`+ }`
`292`	`294`
`293`	`295`	`for (np = 0; np < no; ++np) {`
`294`	`296`	`for (i = 0; i < ECMULT_TABLE_SIZE(WINDOW_A); i++) {`