Skip to content

Commit ff1e2c4

Browse files
committed
Use valid Etags in tests
must have quotes
1 parent 6b9fafb commit ff1e2c4

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/Symfony/Component/HttpFoundation/Tests/ResponseTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -181,11 +181,11 @@ public function testIsNotModifiedLastModified()
181181

182182
public function testIsNotModifiedEtag()
183183
{
184-
$etagOne = 'randomly_generated_etag';
185-
$etagTwo = 'randomly_generated_etag_2';
184+
$etagOne = '"randomly_generated_etag"';
185+
$etagTwo = '"randomly_generated_etag_2"';
186186

187187
$request = new Request();
188-
$request->headers->set('If-None-Match', sprintf('%s, %s, %s', $etagOne, $etagTwo, 'etagThree'));
188+
$request->headers->set('If-None-Match', sprintf('%s, %s, %s', $etagOne, $etagTwo, '"etagThree"'));
189189

190190
$response = new Response();
191191

@@ -208,8 +208,8 @@ public function testIsNotModifiedEtag()
208208

209209
public function testIsNotModifiedWeakEtag()
210210
{
211-
$etag = 'randomly_generated_etag';
212-
$weakEtag = 'W/randomly_generated_etag';
211+
$etag = '"randomly_generated_etag"';
212+
$weakEtag = 'W/"randomly_generated_etag"';
213213

214214
$request = new Request();
215215
$request->headers->set('If-None-Match', $etag);

0 commit comments

Comments
 (0)