settings-ui: [inveniosoftware#855] set membership policy

Author: fenekku

Diff for: invenio_communities/assets/semantic-ui/js/invenio_communities/settings/privileges/CommunityPriviledgesForm.js renamed to invenio_communities/assets/semantic-ui/js/invenio_communities/settings/privileges/CommunityPrivilegesForm.js

@@ -10,6 +10,7 @@
 import { i18next } from "@translations/invenio_communities/i18next";
 import { CommunitySettingsForm } from "..//components/CommunitySettingsForm";
 import _get from "lodash/get";
+import _isEmpty from "lodash/isEmpty";
 import { useField } from "formik";
 import React, { Component } from "react";
 import { RadioField } from "react-invenio-forms";
@@ -18,17 +19,31 @@ import PropTypes from "prop-types";
 
 const VisibilityField = ({ label, formConfig, ...props }) => {
   const [field] = useField(props);
+  const fieldPath = "access.visibility";
+
+  function createHandleChange(radioValue) {
+    function handleChange({ event, data, formikProps }) {
+      formikProps.form.setFieldValue(fieldPath, radioValue);
+      // dependent fields
+      if (radioValue === "restricted") {
+        formikProps.form.setFieldValue("access.member_policy", "closed");
+      }
+    }
+    return handleChange;
+  }
+
   return (
     <>
       {formConfig.access.visibility.map((item) => (
         <React.Fragment key={item.value}>
           <RadioField
             key={item.value}
-            fieldPath="access.visibility"
+            fieldPath={fieldPath}
             label={item.text}
             labelIcon={item.icon}
-            checked={_get(field.value, "access.visibility") === item.value}
+            checked={_get(field.value, fieldPath) === item.value}
             value={item.value}
+            onChange={createHandleChange(item.value)}
           />
           <label className="helptext">{item.helpText}</label>
         </React.Fragment>
@@ -76,14 +91,47 @@ MembersVisibilityField.defaultProps = {
   label: "",
 };
 
+const MemberPolicyField = ({ label, formConfig, ...props }) => {
+  const [field] = useField(props);
+  const isDisabled = _get(field.value, "access.visibility") === "restricted";
+
+  return (
+    <>
+      {formConfig.access.member_policy.map((item) => (
+        <React.Fragment key={item.value}>
+          <RadioField
+            key={item.value}
+            fieldPath="access.member_policy"
+            label={item.text}
+            labelIcon={item.icon}
+            checked={item.value === _get(field.value, "access.member_policy")}
+            value={item.value}
+            disabled={isDisabled}
+          />
+          <label className="helptext">{item.helpText}</label>
+        </React.Fragment>
+      ))}
+    </>
+  );
+};
+
+MemberPolicyField.propTypes = {
+  label: PropTypes.string,
+  formConfig: PropTypes.object.isRequired,
+};
+
+MemberPolicyField.defaultProps = {
+  label: "",
+};
+
 class CommunityPrivilegesForm extends Component {
   getInitialValues = () => {
     return {
       access: {
         visibility: "public",
         members_visibility: "public",
+        member_policy: "closed",
         // TODO: Re-enable once properly integrated to be displayed
-        // member_policy: "open",
         // record_policy: "open",
       },
     };
@@ -105,6 +153,7 @@ class CommunityPrivilegesForm extends Component {
           </Header.Subheader>
         </Header>
         <VisibilityField formConfig={formConfig} />
+
         <Header as="h2" size="small">
           {i18next.t("Members visibility")}
           <Header.Subheader className="mt-5">
@@ -114,6 +163,19 @@ class CommunityPrivilegesForm extends Component {
           </Header.Subheader>
         </Header>
         <MembersVisibilityField formConfig={formConfig} />
+
+        {!_isEmpty(formConfig.access.member_policy) && (
+          <>
+            <Header as="h2" size="small">
+              {i18next.t("Membership Policy")}
+              <Header.Subheader className="mt-5">
+                {i18next.t("Controls if anyone can request to join your community.")}
+              </Header.Subheader>
+            </Header>
+            <MemberPolicyField formConfig={formConfig} />
+          </>
+        )}
+
         {/* TODO: Re-enable once properly integrated to be displayed */}
         {/*
               <Grid.Column width={6}>

Diff for: invenio_communities/assets/semantic-ui/js/invenio_communities/settings/privileges/index.js

@@ -1,4 +1,4 @@
-import CommunityPrivilegesForm from "./CommunityPriviledgesForm";
+import CommunityPrivilegesForm from "./CommunityPrivilegesForm";
 import ReactDOM from "react-dom";
 import React from "react";
 

Diff for: invenio_communities/config.py

@@ -316,3 +316,6 @@
 
 COMMUNITIES_ALWAYS_SHOW_CREATE_LINK = False
 """Controls visibility of 'New Community' btn based on user's permission when set to True."""
+
+COMMUNITIES_ALLOW_MEMBERSHIP_REQUESTS = True
+"""Feature flag for membership request."""

Diff for: invenio_communities/views/communities.py

@@ -82,6 +82,24 @@
 ]
 
 
+MEMBER_POLICY_FIELDS = [
+    {
+        "text": "Open",
+        "value": "open",
+        "icon": "user plus",
+        "helpText": _("Users can request to join your community."),
+    },
+    {
+        "text": "Closed",
+        "value": "closed",
+        "icon": "user times",
+        "helpText": _(
+            "Users cannot request to join your community. Only invited users can become members of your community."
+        ),
+    },
+]
+
+
 HEADER_PERMISSIONS = {
     "read",
     "update",
@@ -307,6 +325,12 @@ def communities_settings_privileges(pid_value, community, community_ui):
     if not permissions["can_manage_access"]:
         raise PermissionDeniedError()
 
+    member_policy = (
+        MEMBER_POLICY_FIELDS
+        if current_app.config["COMMUNITIES_ALLOW_MEMBERSHIP_REQUESTS"]
+        else {}
+    )
+
     return render_community_theme_template(
         "invenio_communities/details/settings/privileges.html",
         theme=community_ui.get("theme", {}),
@@ -315,6 +339,7 @@ def communities_settings_privileges(pid_value, community, community_ui):
             access=dict(
                 visibility=VISIBILITY_FIELDS,
                 members_visibility=MEMBERS_VISIBILITY_FIELDS,
+                member_policy=member_policy,
             ),
         ),
         permissions=permissions,